From: Jonathan Cameron <jic23@kernel.org>
To: Daniel Gomez <dagmcr@gmail.com>
Cc: Stefan Popa <stefan.popa@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org (open list:ANALOG DEVICES INC AD5758
DRIVER), linux-kernel@vger.kernel.org (open list),
javier@dowhile0.org
Subject: Re: [PATCH v2] iio: dac: ad5758: declare missing of table
Date: Sat, 27 Apr 2019 13:59:06 +0100 [thread overview]
Message-ID: <20190427135906.455c468b@archlinux> (raw)
In-Reply-To: <1556055718-14782-1-git-send-email-dagmcr@gmail.com>
On Tue, 23 Apr 2019 23:41:58 +0200
Daniel Gomez <dagmcr@gmail.com> wrote:
> Add missing <of_device_id> table for SPI driver relying on SPI
> device match since compatible is in a DT binding or in a DTS.
>
> Before this patch:
> modinfo drivers/iio/dac/ad5758.ko | grep alias
> alias: spi:ad5758
>
> After this patch:
> modinfo drivers/iio/dac/ad5758.ko | grep alias
> alias: spi:ad5758
> alias: of:N*T*Cadi,ad5758C*
> alias: of:N*T*Cadi,ad5758
>
> Reported-by: Javier Martinez Canillas <javier@dowhile0.org>
> Signed-off-by: Daniel Gomez <dagmcr@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/dac/ad5758.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/iio/dac/ad5758.c b/drivers/iio/dac/ad5758.c
> index 2bdf1b0..e8eaa48 100644
> --- a/drivers/iio/dac/ad5758.c
> +++ b/drivers/iio/dac/ad5758.c
> @@ -11,6 +11,8 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/property.h>
> +#include <linux/of.h>
> +#include <linux/of_device.h>
> #include <linux/spi/spi.h>
> #include <linux/gpio/consumer.h>
>
> @@ -904,9 +906,16 @@ static const struct spi_device_id ad5758_id[] = {
> };
> MODULE_DEVICE_TABLE(spi, ad5758_id);
>
> +static const struct of_device_id ad5758_of_match[] = {
> + { .compatible = "adi,ad5758" },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, ad5758_of_match);
> +
> static struct spi_driver ad5758_driver = {
> .driver = {
> .name = KBUILD_MODNAME,
> + .of_match_table = ad5758_of_match,
> },
> .probe = ad5758_probe,
> .id_table = ad5758_id,
prev parent reply other threads:[~2019-04-27 12:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 21:41 [PATCH v2] iio: dac: ad5758: declare missing of table Daniel Gomez
2019-04-27 12:59 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190427135906.455c468b@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=dagmcr@gmail.com \
--cc=javier@dowhile0.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).