* [PATCH v2] iio: dac: ad5758: declare missing of table
@ 2019-04-23 21:41 Daniel Gomez
2019-04-27 12:59 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Gomez @ 2019-04-23 21:41 UTC (permalink / raw)
To: Stefan Popa, Lars-Peter Clausen, Michael Hennerich,
Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler,
open list:ANALOG DEVICES INC AD5758 DRIVER, open list
Cc: dagmcr, javier, open list:ANALOG DEVICES INC AD5758 DRIVER, open list
Add missing <of_device_id> table for SPI driver relying on SPI
device match since compatible is in a DT binding or in a DTS.
Before this patch:
modinfo drivers/iio/dac/ad5758.ko | grep alias
alias: spi:ad5758
After this patch:
modinfo drivers/iio/dac/ad5758.ko | grep alias
alias: spi:ad5758
alias: of:N*T*Cadi,ad5758C*
alias: of:N*T*Cadi,ad5758
Reported-by: Javier Martinez Canillas <javier@dowhile0.org>
Signed-off-by: Daniel Gomez <dagmcr@gmail.com>
---
drivers/iio/dac/ad5758.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/iio/dac/ad5758.c b/drivers/iio/dac/ad5758.c
index 2bdf1b0..e8eaa48 100644
--- a/drivers/iio/dac/ad5758.c
+++ b/drivers/iio/dac/ad5758.c
@@ -11,6 +11,8 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/property.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
#include <linux/spi/spi.h>
#include <linux/gpio/consumer.h>
@@ -904,9 +906,16 @@ static const struct spi_device_id ad5758_id[] = {
};
MODULE_DEVICE_TABLE(spi, ad5758_id);
+static const struct of_device_id ad5758_of_match[] = {
+ { .compatible = "adi,ad5758" },
+ { },
+};
+MODULE_DEVICE_TABLE(of, ad5758_of_match);
+
static struct spi_driver ad5758_driver = {
.driver = {
.name = KBUILD_MODNAME,
+ .of_match_table = ad5758_of_match,
},
.probe = ad5758_probe,
.id_table = ad5758_id,
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] iio: dac: ad5758: declare missing of table
2019-04-23 21:41 [PATCH v2] iio: dac: ad5758: declare missing of table Daniel Gomez
@ 2019-04-27 12:59 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2019-04-27 12:59 UTC (permalink / raw)
To: Daniel Gomez
Cc: Stefan Popa, Lars-Peter Clausen, Michael Hennerich,
Hartmut Knaack, Peter Meerwald-Stadler,
open list:ANALOG DEVICES INC AD5758 DRIVER, open list, javier
On Tue, 23 Apr 2019 23:41:58 +0200
Daniel Gomez <dagmcr@gmail.com> wrote:
> Add missing <of_device_id> table for SPI driver relying on SPI
> device match since compatible is in a DT binding or in a DTS.
>
> Before this patch:
> modinfo drivers/iio/dac/ad5758.ko | grep alias
> alias: spi:ad5758
>
> After this patch:
> modinfo drivers/iio/dac/ad5758.ko | grep alias
> alias: spi:ad5758
> alias: of:N*T*Cadi,ad5758C*
> alias: of:N*T*Cadi,ad5758
>
> Reported-by: Javier Martinez Canillas <javier@dowhile0.org>
> Signed-off-by: Daniel Gomez <dagmcr@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/dac/ad5758.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/iio/dac/ad5758.c b/drivers/iio/dac/ad5758.c
> index 2bdf1b0..e8eaa48 100644
> --- a/drivers/iio/dac/ad5758.c
> +++ b/drivers/iio/dac/ad5758.c
> @@ -11,6 +11,8 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/property.h>
> +#include <linux/of.h>
> +#include <linux/of_device.h>
> #include <linux/spi/spi.h>
> #include <linux/gpio/consumer.h>
>
> @@ -904,9 +906,16 @@ static const struct spi_device_id ad5758_id[] = {
> };
> MODULE_DEVICE_TABLE(spi, ad5758_id);
>
> +static const struct of_device_id ad5758_of_match[] = {
> + { .compatible = "adi,ad5758" },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, ad5758_of_match);
> +
> static struct spi_driver ad5758_driver = {
> .driver = {
> .name = KBUILD_MODNAME,
> + .of_match_table = ad5758_of_match,
> },
> .probe = ad5758_probe,
> .id_table = ad5758_id,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-27 12:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-23 21:41 [PATCH v2] iio: dac: ad5758: declare missing of table Daniel Gomez
2019-04-27 12:59 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).