From: Jonathan Cameron <jic23@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Stefan Popa <stefan.popa@analog.com>,
Mark Rutland <mark.rutland@arm.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] iio: frequency: adf4371: Add support for output stage mute
Date: Wed, 26 Jun 2019 21:13:31 +0100 [thread overview]
Message-ID: <20190626211331.6e335fe8@archlinux> (raw)
In-Reply-To: <CAL_JsqL-Pxef5oNAx5-crGxL9Q0Ph5gx2Z=KejLSq_jdgVUvbQ@mail.gmail.com>
On Wed, 26 Jun 2019 13:59:49 -0600
Rob Herring <robh+dt@kernel.org> wrote:
> On Mon, Jun 24, 2019 at 9:14 AM Stefan Popa <stefan.popa@analog.com> wrote:
> >
> > Another feature of the ADF4371/ADF4372 is that the supply current to the
> > RF8P and RF8N output stage can shut down until the ADF4371 achieves lock
> > as measured by the digital lock detect circuitry. The mute to lock
> > detect bit (MUTE_LD) in REG25 enables this function.
> >
> > Signed-off-by: Stefan Popa <stefan.popa@analog.com>
> > ---
> > .../devicetree/bindings/iio/frequency/adf4371.yaml | 6 ++++++
>
> If you resend and in the future, please split bindings to separate patch.
>
> > drivers/iio/frequency/adf4371.c | 13 +++++++++++++
> > 2 files changed, 19 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> > index a268a9d..6db8742 100644
> > --- a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> > +++ b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> > @@ -32,6 +32,12 @@ properties:
> > items:
> > - clkin
> >
> > + adi,mute-till-lock-en:
> > + description:
> > + If this property is present, then the supply current to RF8P and RF8N
> > + output stage will shut down until the ADF4371/ADF4372 achieves lock as
> > + measured by the digital lock detect circuitry.
>
> You need to define the type:
>
> type: boolean
>
> Maybe Jonathan will fix up.
Doh. I should have caught that.
Fixed up with
type: boolean
Hopefully I did it right
https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=testing&id=6e68162fcc94ec81c1656e15e6e1893fee0c309a
Thanks Rob!
Jonathan
>
> Rob
prev parent reply other threads:[~2019-06-26 20:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 15:13 [PATCH 4/4] iio: frequency: adf4371: Add support for output stage mute Stefan Popa
2019-06-26 19:48 ` Jonathan Cameron
2019-06-26 20:04 ` Rob Herring
2019-06-26 19:59 ` Rob Herring
2019-06-26 20:13 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626211331.6e335fe8@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).