From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: "David Lechner" <david@lechnology.com>,
linux-iio@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, "Mark Rutland" <mark.rutland@arm.com>,
"Jonathan Cameron" <jic23@jic23.retrosnub.co.uk>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: counter: new bindings for TI eQEP
Date: Fri, 2 Aug 2019 16:25:13 +0900 [thread overview]
Message-ID: <20190802072513.GA30522@icarus> (raw)
In-Reply-To: <20190727204836.1514265d@archlinux>
On Sat, Jul 27, 2019 at 08:48:36PM +0100, Jonathan Cameron wrote:
> On Mon, 22 Jul 2019 10:45:35 -0500
> David Lechner <david@lechnology.com> wrote:
>
> > This documents device tree binding for the Texas Instruments Enhanced
> > Quadrature Encoder Pulse (eQEP) Module found in various TI SoCs.
> >
> > Signed-off-by: David Lechner <david@lechnology.com>
>
> Up to William given it is a counter binding, (unless Rob overrules)
> but new bindings are generally preferred as yaml.
>
> Content looks fine to me.
>
> Thanks,
>
> Jonathan
Rob,
Would you prefer these bindings as yaml, or shall I accept them as they
are now?
William Breathitt Gray
>
> > ---
> > .../devicetree/bindings/counter/ti-eqep.txt | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/counter/ti-eqep.txt
> >
> > diff --git a/Documentation/devicetree/bindings/counter/ti-eqep.txt b/Documentation/devicetree/bindings/counter/ti-eqep.txt
> > new file mode 100644
> > index 000000000000..fbcebc2c2cc2
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/counter/ti-eqep.txt
> > @@ -0,0 +1,18 @@
> > +Texas Instruments Enhanced Quadrature Encoder Pulse (eQEP) Module
> > +
> > +Required properties:
> > +- compatible: Must be "ti,am3352-eqep".
> > +- reg: Physical base address and size of the registers map.
> > +- clocks: Handle to the PWM's functional clock.
> > +- clock-names: Must be "fck".
> > +- interrupts: Handle to the eQEP event interrupt
> > +
> > +Example:
> > +
> > + eqep0: eqep@180 {
> > + compatible = "ti,am3352-eqep";
> > + reg = <0x180 0x80>;
> > + clocks = <&l4ls_gclk>;
> > + clock-names = "fck";
> > + interrupts = <79>;
> > + };
>
next prev parent reply other threads:[~2019-08-02 7:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 15:45 [PATCH 0/4] new driver for TI eQEP David Lechner
2019-07-22 15:45 ` [PATCH 1/4] dt-bindings: counter: new bindings " David Lechner
2019-07-27 19:48 ` Jonathan Cameron
2019-08-02 7:25 ` William Breathitt Gray [this message]
2019-08-02 13:34 ` Rob Herring
2019-08-02 13:58 ` William Breathitt Gray
2019-07-22 15:45 ` [PATCH 2/4] counter: new TI eQEP driver David Lechner
2019-07-30 12:35 ` Uwe Kleine-König
2019-07-30 15:28 ` David Lechner
2019-08-02 9:27 ` William Breathitt Gray
2019-08-02 16:09 ` David Lechner
2019-08-02 16:17 ` David Lechner
2019-08-02 16:40 ` William Breathitt Gray
2019-07-22 15:45 ` [PATCH 3/4] ARM: dts: am33xx: Add nodes for eQEP David Lechner
2019-07-23 8:42 ` Tony Lindgren
2019-07-23 14:45 ` David Lechner
2019-07-23 14:51 ` Tony Lindgren
2019-07-22 15:45 ` [PATCH 4/4] ARM: dts: am335x-boneblue: Enable eQEP David Lechner
2019-07-25 12:40 ` [PATCH 0/4] new driver for TI eQEP William Breathitt Gray
2019-07-25 22:52 ` David Lechner
2019-07-27 19:45 ` Jonathan Cameron
2019-07-30 4:45 ` William Breathitt Gray
2019-08-01 17:37 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190802072513.GA30522@icarus \
--to=vilhelm.gray@gmail.com \
--cc=bcousson@baylibre.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@jic23.retrosnub.co.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).