From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: Rob Herring <robh+dt@kernel.org>
Cc: Mircea Caprioru <mircea.caprioru@analog.com>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Stefan Popa <stefan.popa@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH V3 4/4] dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192
Date: Sun, 18 Aug 2019 20:07:08 +0100 [thread overview]
Message-ID: <20190818200708.659eb4bb@archlinux> (raw)
In-Reply-To: <20190818194627.4bc9571a@archlinux>
On Sun, 18 Aug 2019 19:46:27 +0100
Jonathan Cameron <jic23@kernel.org> wrote:
> On Wed, 14 Aug 2019 20:39:04 -0600
> Rob Herring <robh+dt@kernel.org> wrote:
>
> > On Wed, Aug 14, 2019 at 1:32 AM Mircea Caprioru
> > <mircea.caprioru@analog.com> wrote:
> > >
> > > This patch add device tree binding documentation for AD7192 adc in YAML
> > > format.
> > >
> > > Signed-off-by: Mircea Caprioru <mircea.caprioru@analog.com>
> > > ---
> > > Changelog V2:
> > > - remove description from spi and interrupt properties
> > > - changed the name of the device from ad7192 to adc in the example
> > >
> > > Changelog V3:
> > > - added semicolon at the end of the dt example
> > >
> > > .../bindings/iio/adc/adi,ad7192.yaml | 121 ++++++++++++++++++
> > > 1 file changed, 121 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
>
> For some reason, this patch gave me a git error based on encoding.
> I applied it by hand instead and all seemed fine. Not sure why
> that happened!
>
> Applied to the togreg branch of iio.git and pushed out as testing
> so the autobuilders can play with it.
>
> Thanks,
>
> Jonathan
>
I spoke a bit soon as the build test was still running.
you have const values for the regulators - that doesn't make much sense
to my mind and means your example gives warnings...
items:
- const: dvdd
/iio/Documentation/devicetree/bindings/iio/adc/adi,ad7192.example.dt.yaml: adc@0: dvdd-supply:0: 'dvdd' was expected
I've dropped this and will pick up in v4.
thanks,
Jonathan
next prev parent reply other threads:[~2019-08-18 19:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 7:31 [PATCH V3 1/4] staging: iio: adc: ad7192: Add low_pass_3db_filter_frequency Mircea Caprioru
2019-08-14 7:31 ` [PATCH V3 2/4] iio: adc: ad_sigma_delta: Export ad_sd_calibrate Mircea Caprioru
2019-08-18 18:35 ` Jonathan Cameron
2019-08-14 7:31 ` [PATCH V3 3/4] staging: iio: adc: ad7192: Add system calibration support Mircea Caprioru
2019-08-18 18:40 ` Jonathan Cameron
2019-08-14 7:31 ` [PATCH V3 4/4] dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192 Mircea Caprioru
2019-08-15 2:39 ` Rob Herring
2019-08-18 18:46 ` Jonathan Cameron
2019-08-18 19:07 ` Jonathan Cameron [this message]
2019-08-18 18:34 ` [PATCH V3 1/4] staging: iio: adc: ad7192: Add low_pass_3db_filter_frequency Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190818200708.659eb4bb@archlinux \
--to=jic23@jic23.retrosnub.co.uk \
--cc=Michael.Hennerich@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mircea.caprioru@analog.com \
--cc=robh+dt@kernel.org \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).