From: Jonathan Cameron <jic23@kernel.org>
To: Jean-Baptiste Maneyrol <JManeyrol@invensense.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 0/8] add magnetometer support for MPU925x
Date: Sun, 8 Sep 2019 12:42:42 +0100 [thread overview]
Message-ID: <20190908124242.21669f1f@archlinux> (raw)
In-Reply-To: <20190829151801.13014-1-jmaneyrol@invensense.com>
On Thu, 29 Aug 2019 15:18:33 +0000
Jean-Baptiste Maneyrol <JManeyrol@invensense.com> wrote:
> This serie of patches adds support of magnetometer inside MPU925x chips.
> It is using the MPU i2c master to drive the integrated magnetometer and
> read data into the MPU FIFO.
>
> Beware that this is disabling access to the i2c auxiliary bus. Since this
> can break existing setup, it is an optional feature requiring to enable
> the corresponding Kconfig option.
That's not great... People will fail to set that correctly for their
setup even if there is a 'correct' setting.
So we need more information to risk that breakage + discussions of
ways to avoid it. Can we for example check if the auxiliary bus is
in use? (DT binding for example - check for the i2c-gate node?)
Jonathan
>
> Jean-Baptiste Maneyrol (8):
> iio: imu: inv_mpu6050: disable i2c mux for 925x under Kconfig
> iio: imu: inv_mpu6050: add header include protection macro
> iio: imu: inv_mpu6050: add defines for supporting 9-axis chips
> iio: imu: inv_mpu6050: fix objects syntax in Makefile
> iio: imu: inv_mpu6050: helpers for using i2c master on auxiliary bus
> iio: imu: inv_mpu6050: add magnetometer implementation for MPU925x
> iio: imu: inv_mpu6050: add magnetometer support inside mpu driver
> iio: imu: inv_mpu6050: add fifo support for magnetometer data
>
> drivers/iio/imu/inv_mpu6050/Kconfig | 9 +
> drivers/iio/imu/inv_mpu6050/Makefile | 8 +-
> .../iio/imu/inv_mpu6050/inv_mpu9250_magn.c | 239 ++++++++++++++++++
> .../iio/imu/inv_mpu6050/inv_mpu9250_magn.h | 27 ++
> drivers/iio/imu/inv_mpu6050/inv_mpu_aux.c | 191 ++++++++++++++
> drivers/iio/imu/inv_mpu6050/inv_mpu_aux.h | 46 ++++
> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 141 ++++++++++-
> drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c | 5 +
> drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 79 +++++-
> drivers/iio/imu/inv_mpu6050/inv_mpu_magn.c | 120 +++++++++
> drivers/iio/imu/inv_mpu6050/inv_mpu_magn.h | 107 ++++++++
> drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c | 14 +-
> drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c | 90 ++++++-
> 13 files changed, 1055 insertions(+), 21 deletions(-)
> create mode 100644 drivers/iio/imu/inv_mpu6050/inv_mpu9250_magn.c
> create mode 100644 drivers/iio/imu/inv_mpu6050/inv_mpu9250_magn.h
> create mode 100644 drivers/iio/imu/inv_mpu6050/inv_mpu_aux.c
> create mode 100644 drivers/iio/imu/inv_mpu6050/inv_mpu_aux.h
> create mode 100644 drivers/iio/imu/inv_mpu6050/inv_mpu_magn.c
> create mode 100644 drivers/iio/imu/inv_mpu6050/inv_mpu_magn.h
>
next prev parent reply other threads:[~2019-09-08 11:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 15:18 [PATCH 0/8] add magnetometer support for MPU925x Jean-Baptiste Maneyrol
2019-08-29 15:18 ` [PATCH 1/8] iio: imu: inv_mpu6050: disable i2c mux for 925x under Kconfig Jean-Baptiste Maneyrol
2019-08-29 15:18 ` [PATCH 2/8] iio: imu: inv_mpu6050: add header include protection macro Jean-Baptiste Maneyrol
2019-08-29 15:18 ` [PATCH 3/8] iio: imu: inv_mpu6050: add defines for supporting 9-axis chips Jean-Baptiste Maneyrol
2019-08-29 15:18 ` [PATCH 4/8] iio: imu: inv_mpu6050: fix objects syntax in Makefile Jean-Baptiste Maneyrol
2019-08-29 15:18 ` [PATCH 5/8] iio: imu: inv_mpu6050: helpers for using i2c master on auxiliary bus Jean-Baptiste Maneyrol
2019-09-08 11:57 ` Jonathan Cameron
2019-08-29 15:18 ` [PATCH 6/8] iio: imu: inv_mpu6050: add magnetometer implementation for MPU925x Jean-Baptiste Maneyrol
2019-09-08 11:57 ` Jonathan Cameron
2019-08-29 15:18 ` [PATCH 7/8] iio: imu: inv_mpu6050: add magnetometer support inside mpu driver Jean-Baptiste Maneyrol
2019-09-08 12:05 ` Jonathan Cameron
2019-09-09 16:18 ` Jean-Baptiste Maneyrol
2019-08-29 15:18 ` [PATCH 8/8] iio: imu: inv_mpu6050: add fifo support for magnetometer data Jean-Baptiste Maneyrol
2019-09-08 12:07 ` Jonathan Cameron
2019-09-08 11:42 ` Jonathan Cameron [this message]
2019-09-09 9:55 ` [PATCH 0/8] add magnetometer support for MPU925x Jean-Baptiste Maneyrol
2019-09-10 13:39 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190908124242.21669f1f@archlinux \
--to=jic23@kernel.org \
--cc=JManeyrol@invensense.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).