* [PATCH v1 1/1] iio: fix center temperature of bmc150-accel-core
@ 2019-08-29 5:29 Pascal Bouwmann
2019-09-08 12:13 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Pascal Bouwmann @ 2019-08-29 5:29 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler, linux-iio
The center temperature of the supported devices stored in the constant
BMC150_ACCEL_TEMP_CENTER_VAL is not 24 degrees but 23 degrees.
Signed-off-by: Pascal Bouwmann <bouwmann@tau-tec.de>
---
In the datasheet of the BMC150 device the center temperature is given
wrongly.
See https://community.bosch-sensortec.com/t5/MEMS-sensors-forum/
center-temperature-of-bmc150-device/td-p/9328
diff --git a/drivers/iio/accel/bmc150-accel-core.c
b/drivers/iio/accel/bmc150-accel-core.c
index 807299dd45eb..7e86a5b7ec4e 100644
--- a/drivers/iio/accel/bmc150-accel-core.c
+++ b/drivers/iio/accel/bmc150-accel-core.c
@@ -125,7 +125,7 @@
#define BMC150_ACCEL_SLEEP_1_SEC 0x0F
#define BMC150_ACCEL_REG_TEMP 0x08
-#define BMC150_ACCEL_TEMP_CENTER_VAL 24
+#define BMC150_ACCEL_TEMP_CENTER_VAL 23
#define BMC150_ACCEL_AXIS_TO_REG(axis) (BMC150_ACCEL_REG_XOUT_L +
(axis * 2))
#define BMC150_AUTO_SUSPEND_DELAY_MS 2000
--
Mit freundlichen Grüßen / Best regards
Pascal Bouwmann
+------------------------------------------------------------+
|tau-tec GmbH Managing Director: Michael Ruder|
| HRB 722286, Amtsgericht Stuttgart|
+------------------------------------------------------------+
|Hintere Grabenstr. 30 Phone: +49 7071 70841-0 |
|D-72070 Tübingen Fax: +49 7071 70841-11|
|Germany Mobile: +49 179 1206915|
+------------------------------------------------------------+
|Email: bouwmann@tau-tec.de WWW: http://www.tau-tec.de|
+------------------------------------------------------------+
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] iio: fix center temperature of bmc150-accel-core
2019-08-29 5:29 [PATCH v1 1/1] iio: fix center temperature of bmc150-accel-core Pascal Bouwmann
@ 2019-09-08 12:13 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2019-09-08 12:13 UTC (permalink / raw)
To: Pascal Bouwmann
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler, linux-iio
On Thu, 29 Aug 2019 07:29:41 +0200
Pascal Bouwmann <bouwmann@tau-tec.de> wrote:
> The center temperature of the supported devices stored in the constant
> BMC150_ACCEL_TEMP_CENTER_VAL is not 24 degrees but 23 degrees.
>
> Signed-off-by: Pascal Bouwmann <bouwmann@tau-tec.de>
Your patch is corrupted, but I've manually applied it.
I haven't marked it for stable because I worry a little that this will give
people unexpected changes in long term trends. Better they see that only
on a major kernel version upgrade.
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
> ---
> In the datasheet of the BMC150 device the center temperature is given
> wrongly.
> See https://community.bosch-sensortec.com/t5/MEMS-sensors-forum/
> center-temperature-of-bmc150-device/td-p/9328
>
> diff --git a/drivers/iio/accel/bmc150-accel-core.c
> b/drivers/iio/accel/bmc150-accel-core.c
> index 807299dd45eb..7e86a5b7ec4e 100644
> --- a/drivers/iio/accel/bmc150-accel-core.c
> +++ b/drivers/iio/accel/bmc150-accel-core.c
> @@ -125,7 +125,7 @@
> #define BMC150_ACCEL_SLEEP_1_SEC 0x0F
>
> #define BMC150_ACCEL_REG_TEMP 0x08
> -#define BMC150_ACCEL_TEMP_CENTER_VAL 24
> +#define BMC150_ACCEL_TEMP_CENTER_VAL 23
>
> #define BMC150_ACCEL_AXIS_TO_REG(axis) (BMC150_ACCEL_REG_XOUT_L +
> (axis * 2))
> #define BMC150_AUTO_SUSPEND_DELAY_MS 2000
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-08 12:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-29 5:29 [PATCH v1 1/1] iio: fix center temperature of bmc150-accel-core Pascal Bouwmann
2019-09-08 12:13 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).