[PATCH 1/2] dt-bindings: iio: ad7192: Fix Regulator Properties

[PATCH 1/2] dt-bindings: iio: ad7192: Fix Regulator Properties

[Maxime Ripard]

The AD7192 binding describes two regulator properties, avdd-supply and
dvdd-supply, but describes it as a constant string that must be avdd and
dvdd. This is wrong since a *-supply property is actually a phandle, and
results in warnings when the example is validated (or any device tree using
that device, for that matter).

Let's remove that requirement.

Fixes: f7356e47032c ("dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192")
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
 Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
index 676ec42e1438..9e62f54c891a 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
@@ -43,13 +43,9 @@ properties:
 
   dvdd-supply:
     description: DVdd voltage supply
-    items:
-      - const: dvdd
 
   avdd-supply:
     description: AVdd voltage supply
-    items:
-      - const: avdd
 
   adi,rejection-60-Hz-enable:
     description: |
-- 
2.23.0

[PATCH 2/2] dt-bindings: iio: ad7192: Fix DTC warning in the example

[Maxime Ripard]

The example contains an SPI bus and device, but doesn't have the
appropriate size and address cells size.

This creates a DTC warning when the example is compiled since the default
ones will not match what the device uses. Let's add them to remove that
warning.

Fixes: f7356e47032c ("dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192")
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
 Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
index 9e62f54c891a..567a33a83dce 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
@@ -95,6 +95,9 @@ required:
 examples:
   - |
     spi0 {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
       adc@0 {
         compatible = "adi,ad7192";
         reg = <0>;
-- 
2.23.0

Re: [PATCH 1/2] dt-bindings: iio: ad7192: Fix Regulator Properties

[Rob Herring]

On Wed,  2 Oct 2019 16:45:41 +0200, Maxime Ripard wrote:
> The AD7192 binding describes two regulator properties, avdd-supply and
> dvdd-supply, but describes it as a constant string that must be avdd and
> dvdd. This is wrong since a *-supply property is actually a phandle, and
> results in warnings when the example is validated (or any device tree using
> that device, for that matter).
> 
> Let's remove that requirement.
> 
> Fixes: f7356e47032c ("dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192")
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
> ---
>  Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 4 ----
>  1 file changed, 4 deletions(-)
> 

Applied, thanks.

Rob

Re: [PATCH 2/2] dt-bindings: iio: ad7192: Fix DTC warning in the example

[Rob Herring]

On Wed,  2 Oct 2019 16:45:42 +0200, Maxime Ripard wrote:
> The example contains an SPI bus and device, but doesn't have the
> appropriate size and address cells size.
> 
> This creates a DTC warning when the example is compiled since the default
> ones will not match what the device uses. Let's add them to remove that
> warning.
> 
> Fixes: f7356e47032c ("dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192")
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
> ---
>  Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

Applied, thanks.

Rob

Re: [PATCH 1/2] dt-bindings: iio: ad7192: Fix Regulator Properties

[Jonathan Cameron]

On Wed, 2 Oct 2019 14:14:16 -0500
Rob Herring <robh@kernel.org> wrote:

> On Wed,  2 Oct 2019 16:45:41 +0200, Maxime Ripard wrote:
> > The AD7192 binding describes two regulator properties, avdd-supply and
> > dvdd-supply, but describes it as a constant string that must be avdd and
> > dvdd. This is wrong since a *-supply property is actually a phandle, and
> > results in warnings when the example is validated (or any device tree using
> > that device, for that matter).
> > 
> > Let's remove that requirement.
> > 
> > Fixes: f7356e47032c ("dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192")
> > Signed-off-by: Maxime Ripard <mripard@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 4 ----
> >  1 file changed, 4 deletions(-)
> >   
> 
> Applied, thanks.
> 
> Rob

Thanks for clearing this up.

Jonathan