* [PATCH] iio: adc: mt6577_auxdac: use devm_platform_ioremap_resource
@ 2019-10-13 12:15 jic23
2019-11-04 15:14 ` Ardelean, Alexandru
0 siblings, 1 reply; 3+ messages in thread
From: jic23 @ 2019-10-13 12:15 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron, Zhiyong Tao
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reduces boilerplate. Identified by coccinelle
CHECK drivers/iio/adc/mt6577_auxadc.c
drivers/iio/adc/mt6577_auxadc.c:257:1-18: WARNING: Use devm_platform_ioremap_resource for adc_dev -> reg_base
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Zhiyong Tao <zhiyong.tao@mediatek.com>
---
drivers/iio/adc/mt6577_auxadc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c
index 7bbb64ca3b32..a4776d924f3a 100644
--- a/drivers/iio/adc/mt6577_auxadc.c
+++ b/drivers/iio/adc/mt6577_auxadc.c
@@ -237,7 +237,6 @@ static int mt6577_auxadc_probe(struct platform_device *pdev)
{
struct mt6577_auxadc_device *adc_dev;
unsigned long adc_clk_rate;
- struct resource *res;
struct iio_dev *indio_dev;
int ret;
@@ -253,8 +252,7 @@ static int mt6577_auxadc_probe(struct platform_device *pdev)
indio_dev->channels = mt6577_auxadc_iio_channels;
indio_dev->num_channels = ARRAY_SIZE(mt6577_auxadc_iio_channels);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- adc_dev->reg_base = devm_ioremap_resource(&pdev->dev, res);
+ adc_dev->reg_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(adc_dev->reg_base)) {
dev_err(&pdev->dev, "failed to get auxadc base address\n");
return PTR_ERR(adc_dev->reg_base);
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iio: adc: mt6577_auxdac: use devm_platform_ioremap_resource
2019-10-13 12:15 [PATCH] iio: adc: mt6577_auxdac: use devm_platform_ioremap_resource jic23
@ 2019-11-04 15:14 ` Ardelean, Alexandru
2019-11-09 12:15 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Ardelean, Alexandru @ 2019-11-04 15:14 UTC (permalink / raw)
To: jic23, linux-iio; +Cc: zhiyong.tao, Jonathan.Cameron
On Sun, 2019-10-13 at 13:15 +0100, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Reduces boilerplate. Identified by coccinelle
>
> CHECK drivers/iio/adc/mt6577_auxadc.c
> drivers/iio/adc/mt6577_auxadc.c:257:1-18: WARNING: Use
> devm_platform_ioremap_resource for adc_dev -> reg_base
>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Zhiyong Tao <zhiyong.tao@mediatek.com>
> ---
> drivers/iio/adc/mt6577_auxadc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/mt6577_auxadc.c
> b/drivers/iio/adc/mt6577_auxadc.c
> index 7bbb64ca3b32..a4776d924f3a 100644
> --- a/drivers/iio/adc/mt6577_auxadc.c
> +++ b/drivers/iio/adc/mt6577_auxadc.c
> @@ -237,7 +237,6 @@ static int mt6577_auxadc_probe(struct platform_device
> *pdev)
> {
> struct mt6577_auxadc_device *adc_dev;
> unsigned long adc_clk_rate;
> - struct resource *res;
> struct iio_dev *indio_dev;
> int ret;
>
> @@ -253,8 +252,7 @@ static int mt6577_auxadc_probe(struct platform_device
> *pdev)
> indio_dev->channels = mt6577_auxadc_iio_channels;
> indio_dev->num_channels = ARRAY_SIZE(mt6577_auxadc_iio_channels);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - adc_dev->reg_base = devm_ioremap_resource(&pdev->dev, res);
> + adc_dev->reg_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(adc_dev->reg_base)) {
> dev_err(&pdev->dev, "failed to get auxadc base address\n");
> return PTR_ERR(adc_dev->reg_base);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iio: adc: mt6577_auxdac: use devm_platform_ioremap_resource
2019-11-04 15:14 ` Ardelean, Alexandru
@ 2019-11-09 12:15 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2019-11-09 12:15 UTC (permalink / raw)
To: Ardelean, Alexandru; +Cc: linux-iio, zhiyong.tao, Jonathan.Cameron
On Mon, 4 Nov 2019 15:14:32 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
> On Sun, 2019-10-13 at 13:15 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Reduces boilerplate. Identified by coccinelle
> >
> > CHECK drivers/iio/adc/mt6577_auxadc.c
> > drivers/iio/adc/mt6577_auxadc.c:257:1-18: WARNING: Use
> > devm_platform_ioremap_resource for adc_dev -> reg_base
> >
>
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied.
Thanks,
Jonathan
>
>
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Zhiyong Tao <zhiyong.tao@mediatek.com>
> > ---
> > drivers/iio/adc/mt6577_auxadc.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/iio/adc/mt6577_auxadc.c
> > b/drivers/iio/adc/mt6577_auxadc.c
> > index 7bbb64ca3b32..a4776d924f3a 100644
> > --- a/drivers/iio/adc/mt6577_auxadc.c
> > +++ b/drivers/iio/adc/mt6577_auxadc.c
> > @@ -237,7 +237,6 @@ static int mt6577_auxadc_probe(struct platform_device
> > *pdev)
> > {
> > struct mt6577_auxadc_device *adc_dev;
> > unsigned long adc_clk_rate;
> > - struct resource *res;
> > struct iio_dev *indio_dev;
> > int ret;
> >
> > @@ -253,8 +252,7 @@ static int mt6577_auxadc_probe(struct platform_device
> > *pdev)
> > indio_dev->channels = mt6577_auxadc_iio_channels;
> > indio_dev->num_channels = ARRAY_SIZE(mt6577_auxadc_iio_channels);
> >
> > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - adc_dev->reg_base = devm_ioremap_resource(&pdev->dev, res);
> > + adc_dev->reg_base = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(adc_dev->reg_base)) {
> > dev_err(&pdev->dev, "failed to get auxadc base address\n");
> > return PTR_ERR(adc_dev->reg_base);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-09 12:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-13 12:15 [PATCH] iio: adc: mt6577_auxdac: use devm_platform_ioremap_resource jic23
2019-11-04 15:14 ` Ardelean, Alexandru
2019-11-09 12:15 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).