* [PATCH] iio: adc: cpcap-adc: Fix missing IRQF_ONESHOT as only threaded handler.
@ 2019-10-13 16:21 jic23
2019-10-16 17:24 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: jic23 @ 2019-10-13 16:21 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron, Tony Lindgren
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Coccinelle noticed:
CHECK drivers/iio/adc/cpcap-adc.c
drivers/iio/adc/cpcap-adc.c:1009:9-34: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
As far as I can see this is a simple case of it should be specified
but isn't.
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Tony Lindgren <tony@atomide.com>
---
drivers/iio/adc/cpcap-adc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/cpcap-adc.c b/drivers/iio/adc/cpcap-adc.c
index 2d616cafe75f..5086a337f4c9 100644
--- a/drivers/iio/adc/cpcap-adc.c
+++ b/drivers/iio/adc/cpcap-adc.c
@@ -1008,7 +1008,7 @@ static int cpcap_adc_probe(struct platform_device *pdev)
error = devm_request_threaded_irq(&pdev->dev, ddata->irq, NULL,
cpcap_adc_irq_thread,
- IRQF_TRIGGER_NONE,
+ IRQF_TRIGGER_NONE | IRQF_ONESHOT,
"cpcap-adc", indio_dev);
if (error) {
dev_err(&pdev->dev, "could not get irq: %i\n",
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: cpcap-adc: Fix missing IRQF_ONESHOT as only threaded handler.
2019-10-13 16:21 [PATCH] iio: adc: cpcap-adc: Fix missing IRQF_ONESHOT as only threaded handler jic23
@ 2019-10-16 17:24 ` Tony Lindgren
2019-10-18 19:03 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Tony Lindgren @ 2019-10-16 17:24 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, Jonathan Cameron
* jic23@kernel.org <jic23@kernel.org> [191013 16:24]:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Coccinelle noticed:
> CHECK drivers/iio/adc/cpcap-adc.c
> drivers/iio/adc/cpcap-adc.c:1009:9-34: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
>
> As far as I can see this is a simple case of it should be specified
> but isn't.
Acked-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: cpcap-adc: Fix missing IRQF_ONESHOT as only threaded handler.
2019-10-16 17:24 ` Tony Lindgren
@ 2019-10-18 19:03 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2019-10-18 19:03 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-iio, Jonathan Cameron
On Wed, 16 Oct 2019 10:24:47 -0700
Tony Lindgren <tony@atomide.com> wrote:
> * jic23@kernel.org <jic23@kernel.org> [191013 16:24]:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Coccinelle noticed:
> > CHECK drivers/iio/adc/cpcap-adc.c
> > drivers/iio/adc/cpcap-adc.c:1009:9-34: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
> >
> > As far as I can see this is a simple case of it should be specified
> > but isn't.
>
> Acked-by: Tony Lindgren <tony@atomide.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobulders to play with it
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-18 19:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-13 16:21 [PATCH] iio: adc: cpcap-adc: Fix missing IRQF_ONESHOT as only threaded handler jic23
2019-10-16 17:24 ` Tony Lindgren
2019-10-18 19:03 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).