* [PATCH] iio: adc: vf610: use devm_platform_ioremap_resource
@ 2019-10-13 16:43 jic23
2019-11-04 15:19 ` Ardelean, Alexandru
0 siblings, 1 reply; 3+ messages in thread
From: jic23 @ 2019-10-13 16:43 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron, Fugang Duan
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reduces boilerplate.
Suggested by coccinelle
CHECK drivers/iio/adc/vf610_adc.c
drivers/iio/adc/vf610_adc.c:819:1-11: WARNING: Use devm_platform_ioremap_resource for info -> regs
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Fugang Duan <b38611@freescale.com>
---
drivers/iio/adc/vf610_adc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c
index 98b30475bbc6..cb7380bf07ca 100644
--- a/drivers/iio/adc/vf610_adc.c
+++ b/drivers/iio/adc/vf610_adc.c
@@ -802,7 +802,6 @@ static int vf610_adc_probe(struct platform_device *pdev)
{
struct vf610_adc *info;
struct iio_dev *indio_dev;
- struct resource *mem;
int irq;
int ret;
@@ -815,8 +814,7 @@ static int vf610_adc_probe(struct platform_device *pdev)
info = iio_priv(indio_dev);
info->dev = &pdev->dev;
- mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- info->regs = devm_ioremap_resource(&pdev->dev, mem);
+ info->regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(info->regs))
return PTR_ERR(info->regs);
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: vf610: use devm_platform_ioremap_resource
2019-10-13 16:43 [PATCH] iio: adc: vf610: use devm_platform_ioremap_resource jic23
@ 2019-11-04 15:19 ` Ardelean, Alexandru
2019-11-09 12:29 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Ardelean, Alexandru @ 2019-11-04 15:19 UTC (permalink / raw)
To: jic23, linux-iio; +Cc: Jonathan.Cameron, b38611
On Sun, 2019-10-13 at 17:43 +0100, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Reduces boilerplate.
>
> Suggested by coccinelle
> CHECK drivers/iio/adc/vf610_adc.c
> drivers/iio/adc/vf610_adc.c:819:1-11: WARNING: Use
> devm_platform_ioremap_resource for info -> regs
>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Fugang Duan <b38611@freescale.com>
> ---
> drivers/iio/adc/vf610_adc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c
> index 98b30475bbc6..cb7380bf07ca 100644
> --- a/drivers/iio/adc/vf610_adc.c
> +++ b/drivers/iio/adc/vf610_adc.c
> @@ -802,7 +802,6 @@ static int vf610_adc_probe(struct platform_device
> *pdev)
> {
> struct vf610_adc *info;
> struct iio_dev *indio_dev;
> - struct resource *mem;
> int irq;
> int ret;
>
> @@ -815,8 +814,7 @@ static int vf610_adc_probe(struct platform_device
> *pdev)
> info = iio_priv(indio_dev);
> info->dev = &pdev->dev;
>
> - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - info->regs = devm_ioremap_resource(&pdev->dev, mem);
> + info->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(info->regs))
> return PTR_ERR(info->regs);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: vf610: use devm_platform_ioremap_resource
2019-11-04 15:19 ` Ardelean, Alexandru
@ 2019-11-09 12:29 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2019-11-09 12:29 UTC (permalink / raw)
To: Ardelean, Alexandru; +Cc: linux-iio, Jonathan.Cameron, b38611
On Mon, 4 Nov 2019 15:19:13 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
> On Sun, 2019-10-13 at 17:43 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Reduces boilerplate.
> >
> > Suggested by coccinelle
> > CHECK drivers/iio/adc/vf610_adc.c
> > drivers/iio/adc/vf610_adc.c:819:1-11: WARNING: Use
> > devm_platform_ioremap_resource for info -> regs
> >
>
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied,
Thanks,
J
>
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Fugang Duan <b38611@freescale.com>
> > ---
> > drivers/iio/adc/vf610_adc.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c
> > index 98b30475bbc6..cb7380bf07ca 100644
> > --- a/drivers/iio/adc/vf610_adc.c
> > +++ b/drivers/iio/adc/vf610_adc.c
> > @@ -802,7 +802,6 @@ static int vf610_adc_probe(struct platform_device
> > *pdev)
> > {
> > struct vf610_adc *info;
> > struct iio_dev *indio_dev;
> > - struct resource *mem;
> > int irq;
> > int ret;
> >
> > @@ -815,8 +814,7 @@ static int vf610_adc_probe(struct platform_device
> > *pdev)
> > info = iio_priv(indio_dev);
> > info->dev = &pdev->dev;
> >
> > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - info->regs = devm_ioremap_resource(&pdev->dev, mem);
> > + info->regs = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(info->regs))
> > return PTR_ERR(info->regs);
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-09 12:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-13 16:43 [PATCH] iio: adc: vf610: use devm_platform_ioremap_resource jic23
2019-11-04 15:19 ` Ardelean, Alexandru
2019-11-09 12:29 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).