* [PATCH] iio: light: adux1020: Drop an unwanted semicolon.
@ 2019-10-13 17:38 jic23
2019-10-15 20:12 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: jic23 @ 2019-10-13 17:38 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron, Manivannan Sadhasivam
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Suggested by coccinelle
CHECK drivers/iio/light/adux1020.c
drivers/iio/light/adux1020.c:747:2-3: Unneeded semicolon
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
drivers/iio/light/adux1020.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/light/adux1020.c b/drivers/iio/light/adux1020.c
index 830e5e95d58f..b07797ac10d7 100644
--- a/drivers/iio/light/adux1020.c
+++ b/drivers/iio/light/adux1020.c
@@ -744,7 +744,7 @@ static int adux1020_chip_init(struct adux1020_data *data)
if ((val & ADUX1020_CHIP_ID_MASK) != ADUX1020_CHIP_ID) {
dev_err(&client->dev, "invalid chip id 0x%04x\n", val);
return -ENODEV;
- };
+ }
dev_dbg(&client->dev, "Detected ADUX1020 with chip id: 0x%04x\n", val);
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: light: adux1020: Drop an unwanted semicolon.
2019-10-13 17:38 [PATCH] iio: light: adux1020: Drop an unwanted semicolon jic23
@ 2019-10-15 20:12 ` Jonathan Cameron
2019-10-16 8:47 ` Manivannan Sadhasivam
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2019-10-15 20:12 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron, Manivannan Sadhasivam
On Sun, 13 Oct 2019 18:38:52 +0100
jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Suggested by coccinelle
>
> CHECK drivers/iio/light/adux1020.c
> drivers/iio/light/adux1020.c:747:2-3: Unneeded semicolon
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
0-day sent me the same patch as well.
I've rolled it into the original code as that was still on
testing only which was getting rebased anyway.
Thanks,
Jonathan
> ---
> drivers/iio/light/adux1020.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/light/adux1020.c b/drivers/iio/light/adux1020.c
> index 830e5e95d58f..b07797ac10d7 100644
> --- a/drivers/iio/light/adux1020.c
> +++ b/drivers/iio/light/adux1020.c
> @@ -744,7 +744,7 @@ static int adux1020_chip_init(struct adux1020_data *data)
> if ((val & ADUX1020_CHIP_ID_MASK) != ADUX1020_CHIP_ID) {
> dev_err(&client->dev, "invalid chip id 0x%04x\n", val);
> return -ENODEV;
> - };
> + }
>
> dev_dbg(&client->dev, "Detected ADUX1020 with chip id: 0x%04x\n", val);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: light: adux1020: Drop an unwanted semicolon.
2019-10-15 20:12 ` Jonathan Cameron
@ 2019-10-16 8:47 ` Manivannan Sadhasivam
0 siblings, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2019-10-16 8:47 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio, Jonathan Cameron
Hi Jonathan,
On Tue, Oct 15, 2019 at 09:12:15PM +0100, Jonathan Cameron wrote:
> On Sun, 13 Oct 2019 18:38:52 +0100
> jic23@kernel.org wrote:
>
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Suggested by coccinelle
> >
> > CHECK drivers/iio/light/adux1020.c
> > drivers/iio/light/adux1020.c:747:2-3: Unneeded semicolon
> >
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> 0-day sent me the same patch as well.
>
> I've rolled it into the original code as that was still on
> testing only which was getting rebased anyway.
>
Makes sense!
Thanks,
Mani
> Thanks,
>
> Jonathan
>
> > ---
> > drivers/iio/light/adux1020.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/light/adux1020.c b/drivers/iio/light/adux1020.c
> > index 830e5e95d58f..b07797ac10d7 100644
> > --- a/drivers/iio/light/adux1020.c
> > +++ b/drivers/iio/light/adux1020.c
> > @@ -744,7 +744,7 @@ static int adux1020_chip_init(struct adux1020_data *data)
> > if ((val & ADUX1020_CHIP_ID_MASK) != ADUX1020_CHIP_ID) {
> > dev_err(&client->dev, "invalid chip id 0x%04x\n", val);
> > return -ENODEV;
> > - };
> > + }
> >
> > dev_dbg(&client->dev, "Detected ADUX1020 with chip id: 0x%04x\n", val);
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-16 8:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-13 17:38 [PATCH] iio: light: adux1020: Drop an unwanted semicolon jic23
2019-10-15 20:12 ` Jonathan Cameron
2019-10-16 8:47 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).