* [PATCH 1/2] iio: adc: exynos: Drop a stray semicolon
@ 2019-10-13 12:35 ` jic23
2019-10-13 12:35 ` [PATCH 2/2] iio: adc: exynos: use devm_platform_ioremap_resource jic23
2019-10-14 2:18 ` [PATCH 1/2] iio: adc: exynos: Drop a stray semicolon Chanwoo Choi
0 siblings, 2 replies; 6+ messages in thread
From: jic23 @ 2019-10-13 12:35 UTC (permalink / raw)
To: linux-iio; +Cc: Chanwoo Choi, Jonathan Cameron
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Identified by coccinelle
drivers/iio/adc/exynos_adc.c:654:2-3: Unneeded semicolon
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
drivers/iio/adc/exynos_adc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
index 42a3ced11fbd..b5a497381452 100644
--- a/drivers/iio/adc/exynos_adc.c
+++ b/drivers/iio/adc/exynos_adc.c
@@ -651,7 +651,7 @@ static irqreturn_t exynos_ts_isr(int irq, void *dev_id)
input_sync(info->input);
usleep_range(1000, 1100);
- };
+ }
writel(0, ADC_V1_CLRINTPNDNUP(info->regs));
--
2.23.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] iio: adc: exynos: use devm_platform_ioremap_resource
2019-10-13 12:35 ` [PATCH 1/2] iio: adc: exynos: Drop a stray semicolon jic23
@ 2019-10-13 12:35 ` jic23
2019-10-14 2:18 ` Chanwoo Choi
2019-10-14 2:18 ` [PATCH 1/2] iio: adc: exynos: Drop a stray semicolon Chanwoo Choi
1 sibling, 1 reply; 6+ messages in thread
From: jic23 @ 2019-10-13 12:35 UTC (permalink / raw)
To: linux-iio; +Cc: Chanwoo Choi, Jonathan Cameron
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reduce local boilerplate.
Identified by coccinelle
drivers/iio/adc/exynos_adc.c:792:1-11: WARNING: Use devm_platform_ioremap_resource for info -> regs
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
drivers/iio/adc/exynos_adc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
index b5a497381452..2df7d057b249 100644
--- a/drivers/iio/adc/exynos_adc.c
+++ b/drivers/iio/adc/exynos_adc.c
@@ -769,7 +769,6 @@ static int exynos_adc_probe(struct platform_device *pdev)
struct device_node *np = pdev->dev.of_node;
struct s3c2410_ts_mach_info *pdata = dev_get_platdata(&pdev->dev);
struct iio_dev *indio_dev = NULL;
- struct resource *mem;
bool has_ts = false;
int ret = -ENODEV;
int irq;
@@ -788,8 +787,7 @@ static int exynos_adc_probe(struct platform_device *pdev)
return -EINVAL;
}
- mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- info->regs = devm_ioremap_resource(&pdev->dev, mem);
+ info->regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(info->regs))
return PTR_ERR(info->regs);
--
2.23.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] iio: adc: exynos: Drop a stray semicolon
2019-10-13 12:35 ` [PATCH 1/2] iio: adc: exynos: Drop a stray semicolon jic23
2019-10-13 12:35 ` [PATCH 2/2] iio: adc: exynos: use devm_platform_ioremap_resource jic23
@ 2019-10-14 2:18 ` Chanwoo Choi
2019-10-18 18:59 ` Jonathan Cameron
1 sibling, 1 reply; 6+ messages in thread
From: Chanwoo Choi @ 2019-10-14 2:18 UTC (permalink / raw)
To: jic23, linux-iio; +Cc: Jonathan Cameron, cpgs (cpgs@samsung.com)
Hi,
On 19. 10. 13. 오후 9:35, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Identified by coccinelle
> drivers/iio/adc/exynos_adc.c:654:2-3: Unneeded semicolon
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/iio/adc/exynos_adc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
> index 42a3ced11fbd..b5a497381452 100644
> --- a/drivers/iio/adc/exynos_adc.c
> +++ b/drivers/iio/adc/exynos_adc.c
> @@ -651,7 +651,7 @@ static irqreturn_t exynos_ts_isr(int irq, void *dev_id)
> input_sync(info->input);
>
> usleep_range(1000, 1100);
> - };
> + }
>
> writel(0, ADC_V1_CLRINTPNDNUP(info->regs));
>
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] iio: adc: exynos: use devm_platform_ioremap_resource
2019-10-13 12:35 ` [PATCH 2/2] iio: adc: exynos: use devm_platform_ioremap_resource jic23
@ 2019-10-14 2:18 ` Chanwoo Choi
2019-10-18 19:00 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Chanwoo Choi @ 2019-10-14 2:18 UTC (permalink / raw)
To: jic23, linux-iio; +Cc: Jonathan Cameron, cpgs (cpgs@samsung.com)
Hi,
On 19. 10. 13. 오후 9:35, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Reduce local boilerplate.
> Identified by coccinelle
> drivers/iio/adc/exynos_adc.c:792:1-11: WARNING: Use devm_platform_ioremap_resource for info -> regs
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/iio/adc/exynos_adc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
> index b5a497381452..2df7d057b249 100644
> --- a/drivers/iio/adc/exynos_adc.c
> +++ b/drivers/iio/adc/exynos_adc.c
> @@ -769,7 +769,6 @@ static int exynos_adc_probe(struct platform_device *pdev)
> struct device_node *np = pdev->dev.of_node;
> struct s3c2410_ts_mach_info *pdata = dev_get_platdata(&pdev->dev);
> struct iio_dev *indio_dev = NULL;
> - struct resource *mem;
> bool has_ts = false;
> int ret = -ENODEV;
> int irq;
> @@ -788,8 +787,7 @@ static int exynos_adc_probe(struct platform_device *pdev)
> return -EINVAL;
> }
>
> - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - info->regs = devm_ioremap_resource(&pdev->dev, mem);
> + info->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(info->regs))
> return PTR_ERR(info->regs);
>
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] iio: adc: exynos: Drop a stray semicolon
2019-10-14 2:18 ` [PATCH 1/2] iio: adc: exynos: Drop a stray semicolon Chanwoo Choi
@ 2019-10-18 18:59 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2019-10-18 18:59 UTC (permalink / raw)
To: Chanwoo Choi; +Cc: linux-iio, Jonathan Cameron, cpgs (cpgs@samsung.com)
On Mon, 14 Oct 2019 11:18:43 +0900
Chanwoo Choi <cw00.choi@samsung.com> wrote:
> Hi,
>
> On 19. 10. 13. 오후 9:35, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Identified by coccinelle
> > drivers/iio/adc/exynos_adc.c:654:2-3: Unneeded semicolon
> >
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > ---
> > drivers/iio/adc/exynos_adc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
> > index 42a3ced11fbd..b5a497381452 100644
> > --- a/drivers/iio/adc/exynos_adc.c
> > +++ b/drivers/iio/adc/exynos_adc.c
> > @@ -651,7 +651,7 @@ static irqreturn_t exynos_ts_isr(int irq, void *dev_id)
> > input_sync(info->input);
> >
> > usleep_range(1000, 1100);
> > - };
> > + }
> >
> > writel(0, ADC_V1_CLRINTPNDNUP(info->regs));
> >
> >
>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Applied.
Thanks,
Jonathan
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] iio: adc: exynos: use devm_platform_ioremap_resource
2019-10-14 2:18 ` Chanwoo Choi
@ 2019-10-18 19:00 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2019-10-18 19:00 UTC (permalink / raw)
To: Chanwoo Choi; +Cc: linux-iio, Jonathan Cameron, cpgs (cpgs@samsung.com)
On Mon, 14 Oct 2019 11:18:58 +0900
Chanwoo Choi <cw00.choi@samsung.com> wrote:
> Hi,
>
> On 19. 10. 13. 오후 9:35, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Reduce local boilerplate.
> > Identified by coccinelle
> > drivers/iio/adc/exynos_adc.c:792:1-11: WARNING: Use devm_platform_ioremap_resource for info -> regs
> >
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > ---
> > drivers/iio/adc/exynos_adc.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
> > index b5a497381452..2df7d057b249 100644
> > --- a/drivers/iio/adc/exynos_adc.c
> > +++ b/drivers/iio/adc/exynos_adc.c
> > @@ -769,7 +769,6 @@ static int exynos_adc_probe(struct platform_device *pdev)
> > struct device_node *np = pdev->dev.of_node;
> > struct s3c2410_ts_mach_info *pdata = dev_get_platdata(&pdev->dev);
> > struct iio_dev *indio_dev = NULL;
> > - struct resource *mem;
> > bool has_ts = false;
> > int ret = -ENODEV;
> > int irq;
> > @@ -788,8 +787,7 @@ static int exynos_adc_probe(struct platform_device *pdev)
> > return -EINVAL;
> > }
> >
> > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - info->regs = devm_ioremap_resource(&pdev->dev, mem);
> > + info->regs = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(info->regs))
> > return PTR_ERR(info->regs);
> >
> >
>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>
Applied. Thanks,
Jonathan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-18 19:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20191013123734epcas4p138622f17adc5c3baaeba8eb8f4cff1bb@epcas4p1.samsung.com>
2019-10-13 12:35 ` [PATCH 1/2] iio: adc: exynos: Drop a stray semicolon jic23
2019-10-13 12:35 ` [PATCH 2/2] iio: adc: exynos: use devm_platform_ioremap_resource jic23
2019-10-14 2:18 ` Chanwoo Choi
2019-10-18 19:00 ` Jonathan Cameron
2019-10-14 2:18 ` [PATCH 1/2] iio: adc: exynos: Drop a stray semicolon Chanwoo Choi
2019-10-18 18:59 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).