From: Jonathan Cameron <jic23@kernel.org>
To: "Nuno Sá" <nuno.sa@analog.com>
Cc: <linux-iio@vger.kernel.org>, Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [PATCH 2/2] iio: adis16480: Add debugfs_reg_access entry
Date: Sun, 27 Oct 2019 16:37:00 +0000 [thread overview]
Message-ID: <20191027163700.16d7d3f8@archlinux> (raw)
In-Reply-To: <20191025124508.166648-2-nuno.sa@analog.com>
On Fri, 25 Oct 2019 14:45:08 +0200
Nuno Sá <nuno.sa@analog.com> wrote:
> The driver is defining debugfs entries by calling
> `adis16480_debugfs_init()`. However, those entries are attached to the
> iio_dev debugfs entry which won't exist if no debugfs_reg_access
> callback is provided.
>
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
As you are respinning the first one and this is probably stable
material as well, please add a fixes tag for v2.
Thanks,
Jonathan
> ---
> drivers/iio/imu/adis16480.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c
> index 3b53bbb11bfb..94aa1c57e605 100644
> --- a/drivers/iio/imu/adis16480.c
> +++ b/drivers/iio/imu/adis16480.c
> @@ -921,6 +921,7 @@ static const struct iio_info adis16480_info = {
> .read_raw = &adis16480_read_raw,
> .write_raw = &adis16480_write_raw,
> .update_scan_mode = adis_update_scan_mode,
> + .debugfs_reg_access = adis_debugfs_reg_access,
> };
>
> static int adis16480_stop_device(struct iio_dev *indio_dev)
next prev parent reply other threads:[~2019-10-27 16:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 12:45 [PATCH 1/2] iio: adis16480: Fix scales factors Nuno Sá
2019-10-25 12:45 ` [PATCH 2/2] iio: adis16480: Add debugfs_reg_access entry Nuno Sá
2019-10-27 16:37 ` Jonathan Cameron [this message]
2019-10-28 8:25 ` Sa, Nuno
2019-10-29 18:25 ` Jonathan Cameron
2019-10-30 7:53 ` Sa, Nuno
2019-10-27 16:24 ` [PATCH 1/2] iio: adis16480: Fix scales factors Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191027163700.16d7d3f8@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).