From: Jonathan Cameron <jic23@kernel.org>
To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>,
"raltherr@google.com" <raltherr@google.com>
Subject: Re: [PATCH] iio: adc: aspeed: use devm_platform_ioremap_resource
Date: Sat, 9 Nov 2019 12:13:50 +0000 [thread overview]
Message-ID: <20191109121350.6db10b02@archlinux> (raw)
In-Reply-To: <1be83f4fa8c1c87d41f17c9180651bc0ced625e7.camel@analog.com>
On Mon, 4 Nov 2019 15:12:58 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
> On Sun, 2019-10-13 at 12:37 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Reduces boilerplate.
> >
> > Identified by: Coccinelle / coccicheck
> >
> > CHECK drivers/iio/adc/aspeed_adc.c
> > drivers/iio/adc/aspeed_adc.c:189:1-11: WARNING: Use
> > devm_platform_ioremap_resource for data -> base
> >
>
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied. Thanks,
Jonathan
>
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Rick Altherr <raltherr@google.com>
> > ---
> > drivers/iio/adc/aspeed_adc.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/iio/adc/aspeed_adc.c b/drivers/iio/adc/aspeed_adc.c
> > index d3fc39df535d..1e5375235cfe 100644
> > --- a/drivers/iio/adc/aspeed_adc.c
> > +++ b/drivers/iio/adc/aspeed_adc.c
> > @@ -173,7 +173,6 @@ static int aspeed_adc_probe(struct platform_device
> > *pdev)
> > struct iio_dev *indio_dev;
> > struct aspeed_adc_data *data;
> > const struct aspeed_adc_model_data *model_data;
> > - struct resource *res;
> > const char *clk_parent_name;
> > int ret;
> > u32 adc_engine_control_reg_val;
> > @@ -185,8 +184,7 @@ static int aspeed_adc_probe(struct platform_device
> > *pdev)
> > data = iio_priv(indio_dev);
> > data->dev = &pdev->dev;
> >
> > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - data->base = devm_ioremap_resource(&pdev->dev, res);
> > + data->base = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(data->base))
> > return PTR_ERR(data->base);
> >
prev parent reply other threads:[~2019-11-09 12:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 11:37 [PATCH] iio: adc: aspeed: use devm_platform_ioremap_resource jic23
2019-11-04 15:12 ` Ardelean, Alexandru
2019-11-09 12:13 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191109121350.6db10b02@archlinux \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=alexandru.Ardelean@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=raltherr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).