* [PATCH] iio: adc: aspeed: use devm_platform_ioremap_resource
@ 2019-10-13 11:37 jic23
2019-11-04 15:12 ` Ardelean, Alexandru
0 siblings, 1 reply; 3+ messages in thread
From: jic23 @ 2019-10-13 11:37 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron, Rick Altherr
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reduces boilerplate.
Identified by: Coccinelle / coccicheck
CHECK drivers/iio/adc/aspeed_adc.c
drivers/iio/adc/aspeed_adc.c:189:1-11: WARNING: Use devm_platform_ioremap_resource for data -> base
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Rick Altherr <raltherr@google.com>
---
drivers/iio/adc/aspeed_adc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/iio/adc/aspeed_adc.c b/drivers/iio/adc/aspeed_adc.c
index d3fc39df535d..1e5375235cfe 100644
--- a/drivers/iio/adc/aspeed_adc.c
+++ b/drivers/iio/adc/aspeed_adc.c
@@ -173,7 +173,6 @@ static int aspeed_adc_probe(struct platform_device *pdev)
struct iio_dev *indio_dev;
struct aspeed_adc_data *data;
const struct aspeed_adc_model_data *model_data;
- struct resource *res;
const char *clk_parent_name;
int ret;
u32 adc_engine_control_reg_val;
@@ -185,8 +184,7 @@ static int aspeed_adc_probe(struct platform_device *pdev)
data = iio_priv(indio_dev);
data->dev = &pdev->dev;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- data->base = devm_ioremap_resource(&pdev->dev, res);
+ data->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(data->base))
return PTR_ERR(data->base);
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: aspeed: use devm_platform_ioremap_resource
2019-10-13 11:37 [PATCH] iio: adc: aspeed: use devm_platform_ioremap_resource jic23
@ 2019-11-04 15:12 ` Ardelean, Alexandru
2019-11-09 12:13 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Ardelean, Alexandru @ 2019-11-04 15:12 UTC (permalink / raw)
To: jic23, linux-iio; +Cc: Jonathan.Cameron, raltherr
On Sun, 2019-10-13 at 12:37 +0100, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Reduces boilerplate.
>
> Identified by: Coccinelle / coccicheck
>
> CHECK drivers/iio/adc/aspeed_adc.c
> drivers/iio/adc/aspeed_adc.c:189:1-11: WARNING: Use
> devm_platform_ioremap_resource for data -> base
>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Rick Altherr <raltherr@google.com>
> ---
> drivers/iio/adc/aspeed_adc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/aspeed_adc.c b/drivers/iio/adc/aspeed_adc.c
> index d3fc39df535d..1e5375235cfe 100644
> --- a/drivers/iio/adc/aspeed_adc.c
> +++ b/drivers/iio/adc/aspeed_adc.c
> @@ -173,7 +173,6 @@ static int aspeed_adc_probe(struct platform_device
> *pdev)
> struct iio_dev *indio_dev;
> struct aspeed_adc_data *data;
> const struct aspeed_adc_model_data *model_data;
> - struct resource *res;
> const char *clk_parent_name;
> int ret;
> u32 adc_engine_control_reg_val;
> @@ -185,8 +184,7 @@ static int aspeed_adc_probe(struct platform_device
> *pdev)
> data = iio_priv(indio_dev);
> data->dev = &pdev->dev;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - data->base = devm_ioremap_resource(&pdev->dev, res);
> + data->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(data->base))
> return PTR_ERR(data->base);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: aspeed: use devm_platform_ioremap_resource
2019-11-04 15:12 ` Ardelean, Alexandru
@ 2019-11-09 12:13 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2019-11-09 12:13 UTC (permalink / raw)
To: Ardelean, Alexandru; +Cc: linux-iio, Jonathan.Cameron, raltherr
On Mon, 4 Nov 2019 15:12:58 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
> On Sun, 2019-10-13 at 12:37 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Reduces boilerplate.
> >
> > Identified by: Coccinelle / coccicheck
> >
> > CHECK drivers/iio/adc/aspeed_adc.c
> > drivers/iio/adc/aspeed_adc.c:189:1-11: WARNING: Use
> > devm_platform_ioremap_resource for data -> base
> >
>
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied. Thanks,
Jonathan
>
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Rick Altherr <raltherr@google.com>
> > ---
> > drivers/iio/adc/aspeed_adc.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/iio/adc/aspeed_adc.c b/drivers/iio/adc/aspeed_adc.c
> > index d3fc39df535d..1e5375235cfe 100644
> > --- a/drivers/iio/adc/aspeed_adc.c
> > +++ b/drivers/iio/adc/aspeed_adc.c
> > @@ -173,7 +173,6 @@ static int aspeed_adc_probe(struct platform_device
> > *pdev)
> > struct iio_dev *indio_dev;
> > struct aspeed_adc_data *data;
> > const struct aspeed_adc_model_data *model_data;
> > - struct resource *res;
> > const char *clk_parent_name;
> > int ret;
> > u32 adc_engine_control_reg_val;
> > @@ -185,8 +184,7 @@ static int aspeed_adc_probe(struct platform_device
> > *pdev)
> > data = iio_priv(indio_dev);
> > data->dev = &pdev->dev;
> >
> > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - data->base = devm_ioremap_resource(&pdev->dev, res);
> > + data->base = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(data->base))
> > return PTR_ERR(data->base);
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-09 12:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-13 11:37 [PATCH] iio: adc: aspeed: use devm_platform_ioremap_resource jic23
2019-11-04 15:12 ` Ardelean, Alexandru
2019-11-09 12:13 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).