* [PATCH] iio: dac: vf610: Use devm_platform_ioremap_resource
@ 2019-10-13 17:17 jic23
2019-11-04 15:18 ` Ardelean, Alexandru
0 siblings, 1 reply; 3+ messages in thread
From: jic23 @ 2019-10-13 17:17 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron, Sanchayan Maity
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reduce local boilerplate.
Suggested by coccinelle
CHECK drivers/iio/dac/vf610_dac.c
drivers/iio/dac/vf610_dac.c:189:1-11: WARNING: Use devm_platform_ioremap_resource for info -> regs
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Sanchayan Maity <maitysanchayan@gmail.com>
---
drivers/iio/dac/vf610_dac.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/iio/dac/vf610_dac.c b/drivers/iio/dac/vf610_dac.c
index 0ec4d2609ef9..71f8a5c471c4 100644
--- a/drivers/iio/dac/vf610_dac.c
+++ b/drivers/iio/dac/vf610_dac.c
@@ -172,7 +172,6 @@ static int vf610_dac_probe(struct platform_device *pdev)
{
struct iio_dev *indio_dev;
struct vf610_dac *info;
- struct resource *mem;
int ret;
indio_dev = devm_iio_device_alloc(&pdev->dev,
@@ -185,8 +184,7 @@ static int vf610_dac_probe(struct platform_device *pdev)
info = iio_priv(indio_dev);
info->dev = &pdev->dev;
- mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- info->regs = devm_ioremap_resource(&pdev->dev, mem);
+ info->regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(info->regs))
return PTR_ERR(info->regs);
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iio: dac: vf610: Use devm_platform_ioremap_resource
2019-10-13 17:17 [PATCH] iio: dac: vf610: Use devm_platform_ioremap_resource jic23
@ 2019-11-04 15:18 ` Ardelean, Alexandru
2019-11-09 12:32 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Ardelean, Alexandru @ 2019-11-04 15:18 UTC (permalink / raw)
To: jic23, linux-iio; +Cc: Jonathan.Cameron, maitysanchayan
On Sun, 2019-10-13 at 18:17 +0100, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Reduce local boilerplate.
> Suggested by coccinelle
>
> CHECK drivers/iio/dac/vf610_dac.c
> drivers/iio/dac/vf610_dac.c:189:1-11: WARNING: Use
> devm_platform_ioremap_resource for info -> regs
>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
> drivers/iio/dac/vf610_dac.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/dac/vf610_dac.c b/drivers/iio/dac/vf610_dac.c
> index 0ec4d2609ef9..71f8a5c471c4 100644
> --- a/drivers/iio/dac/vf610_dac.c
> +++ b/drivers/iio/dac/vf610_dac.c
> @@ -172,7 +172,6 @@ static int vf610_dac_probe(struct platform_device
> *pdev)
> {
> struct iio_dev *indio_dev;
> struct vf610_dac *info;
> - struct resource *mem;
> int ret;
>
> indio_dev = devm_iio_device_alloc(&pdev->dev,
> @@ -185,8 +184,7 @@ static int vf610_dac_probe(struct platform_device
> *pdev)
> info = iio_priv(indio_dev);
> info->dev = &pdev->dev;
>
> - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - info->regs = devm_ioremap_resource(&pdev->dev, mem);
> + info->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(info->regs))
> return PTR_ERR(info->regs);
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iio: dac: vf610: Use devm_platform_ioremap_resource
2019-11-04 15:18 ` Ardelean, Alexandru
@ 2019-11-09 12:32 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2019-11-09 12:32 UTC (permalink / raw)
To: Ardelean, Alexandru; +Cc: linux-iio, Jonathan.Cameron, maitysanchayan
On Mon, 4 Nov 2019 15:18:09 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
> On Sun, 2019-10-13 at 18:17 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Reduce local boilerplate.
> > Suggested by coccinelle
> >
> > CHECK drivers/iio/dac/vf610_dac.c
> > drivers/iio/dac/vf610_dac.c:189:1-11: WARNING: Use
> > devm_platform_ioremap_resource for info -> regs
> >
>
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied,
Thanks,
Jonathan
>
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Sanchayan Maity <maitysanchayan@gmail.com>
> > ---
> > drivers/iio/dac/vf610_dac.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/iio/dac/vf610_dac.c b/drivers/iio/dac/vf610_dac.c
> > index 0ec4d2609ef9..71f8a5c471c4 100644
> > --- a/drivers/iio/dac/vf610_dac.c
> > +++ b/drivers/iio/dac/vf610_dac.c
> > @@ -172,7 +172,6 @@ static int vf610_dac_probe(struct platform_device
> > *pdev)
> > {
> > struct iio_dev *indio_dev;
> > struct vf610_dac *info;
> > - struct resource *mem;
> > int ret;
> >
> > indio_dev = devm_iio_device_alloc(&pdev->dev,
> > @@ -185,8 +184,7 @@ static int vf610_dac_probe(struct platform_device
> > *pdev)
> > info = iio_priv(indio_dev);
> > info->dev = &pdev->dev;
> >
> > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - info->regs = devm_ioremap_resource(&pdev->dev, mem);
> > + info->regs = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(info->regs))
> > return PTR_ERR(info->regs);
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-09 12:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-13 17:17 [PATCH] iio: dac: vf610: Use devm_platform_ioremap_resource jic23
2019-11-04 15:18 ` Ardelean, Alexandru
2019-11-09 12:32 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).