* [PATCH v2] iio: cros_ec_baro: set info_mask_shared_by_all_available field
@ 2019-11-06 17:55 Gwendal Grignou
2019-11-10 15:22 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Gwendal Grignou @ 2019-11-06 17:55 UTC (permalink / raw)
To: fabien.lahoudere, enric.balletbo, jic23; +Cc: linux-iio, Gwendal Grignou
Field was already set for light/proximity and
accelerometer/gyroscope/magnetometer sensors.
Fixes: ae7b02ad2f32 ("iio: common: cros_ec_sensors: Expose
cros_ec_sensors frequency range via iio sysfs")
Change-Id: Iffa4c47979994eaaf1abb609c75c080923ecf600
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
---
Changes in v2:
Forgot to add read_avail entry point.
drivers/iio/pressure/cros_ec_baro.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/iio/pressure/cros_ec_baro.c b/drivers/iio/pressure/cros_ec_baro.c
index 2354302375de..52f53f3123b1 100644
--- a/drivers/iio/pressure/cros_ec_baro.c
+++ b/drivers/iio/pressure/cros_ec_baro.c
@@ -114,6 +114,7 @@ static int cros_ec_baro_write(struct iio_dev *indio_dev,
static const struct iio_info cros_ec_baro_info = {
.read_raw = &cros_ec_baro_read,
.write_raw = &cros_ec_baro_write,
+ .read_avail = &cros_ec_sensors_core_read_avail,
};
static int cros_ec_baro_probe(struct platform_device *pdev)
@@ -149,6 +150,8 @@ static int cros_ec_baro_probe(struct platform_device *pdev)
BIT(IIO_CHAN_INFO_SCALE) |
BIT(IIO_CHAN_INFO_SAMP_FREQ) |
BIT(IIO_CHAN_INFO_FREQUENCY);
+ channel->info_mask_shared_by_all_available =
+ BIT(IIO_CHAN_INFO_SAMP_FREQ);
channel->scan_type.realbits = CROS_EC_SENSOR_BITS;
channel->scan_type.storagebits = CROS_EC_SENSOR_BITS;
channel->scan_type.shift = 0;
--
2.24.0.432.g9d3f5f5b63-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] iio: cros_ec_baro: set info_mask_shared_by_all_available field
2019-11-06 17:55 [PATCH v2] iio: cros_ec_baro: set info_mask_shared_by_all_available field Gwendal Grignou
@ 2019-11-10 15:22 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2019-11-10 15:22 UTC (permalink / raw)
To: Gwendal Grignou; +Cc: fabien.lahoudere, enric.balletbo, linux-iio
On Wed, 6 Nov 2019 09:55:33 -0800
Gwendal Grignou <gwendal@chromium.org> wrote:
> Field was already set for light/proximity and
> accelerometer/gyroscope/magnetometer sensors.
>
> Fixes: ae7b02ad2f32 ("iio: common: cros_ec_sensors: Expose
> cros_ec_sensors frequency range via iio sysfs")
>
> Change-Id: Iffa4c47979994eaaf1abb609c75c080923ecf600
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Seems independent of the large set you have in flight so applied
to the togreg branch of iio.git and pushed out as testing.
Thanks,
Jonathan
> ---
> Changes in v2:
> Forgot to add read_avail entry point.
>
> drivers/iio/pressure/cros_ec_baro.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/iio/pressure/cros_ec_baro.c b/drivers/iio/pressure/cros_ec_baro.c
> index 2354302375de..52f53f3123b1 100644
> --- a/drivers/iio/pressure/cros_ec_baro.c
> +++ b/drivers/iio/pressure/cros_ec_baro.c
> @@ -114,6 +114,7 @@ static int cros_ec_baro_write(struct iio_dev *indio_dev,
> static const struct iio_info cros_ec_baro_info = {
> .read_raw = &cros_ec_baro_read,
> .write_raw = &cros_ec_baro_write,
> + .read_avail = &cros_ec_sensors_core_read_avail,
> };
>
> static int cros_ec_baro_probe(struct platform_device *pdev)
> @@ -149,6 +150,8 @@ static int cros_ec_baro_probe(struct platform_device *pdev)
> BIT(IIO_CHAN_INFO_SCALE) |
> BIT(IIO_CHAN_INFO_SAMP_FREQ) |
> BIT(IIO_CHAN_INFO_FREQUENCY);
> + channel->info_mask_shared_by_all_available =
> + BIT(IIO_CHAN_INFO_SAMP_FREQ);
> channel->scan_type.realbits = CROS_EC_SENSOR_BITS;
> channel->scan_type.storagebits = CROS_EC_SENSOR_BITS;
> channel->scan_type.shift = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-10 15:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06 17:55 [PATCH v2] iio: cros_ec_baro: set info_mask_shared_by_all_available field Gwendal Grignou
2019-11-10 15:22 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).