From: Jonathan Cameron <jic23@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Matt Ranostay <matt.ranostay@konsulko.com>
Subject: Re: [PATCH] iio: atlas-ph-sensor: Drop GPIO include
Date: Sat, 7 Dec 2019 10:16:54 +0000 [thread overview]
Message-ID: <20191207101654.66c807cf@archlinux> (raw)
In-Reply-To: <20191202091837.82150-1-linus.walleij@linaro.org>
On Mon, 2 Dec 2019 10:18:37 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:
> The driver includes <linux/gpio.h> yet fails to use symbols
> from any the header so drop the include.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
+CC Matt
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to do something or other.
Thanks,
Jonathan
> ---
> drivers/iio/chemical/atlas-ph-sensor.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/chemical/atlas-ph-sensor.c b/drivers/iio/chemical/atlas-ph-sensor.c
> index 6c175eb1c7a7..b7c20c74239b 100644
> --- a/drivers/iio/chemical/atlas-ph-sensor.c
> +++ b/drivers/iio/chemical/atlas-ph-sensor.c
> @@ -14,7 +14,6 @@
> #include <linux/err.h>
> #include <linux/irq.h>
> #include <linux/irq_work.h>
> -#include <linux/gpio.h>
> #include <linux/i2c.h>
> #include <linux/of_device.h>
> #include <linux/regmap.h>
next prev parent reply other threads:[~2019-12-07 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 9:18 [PATCH] iio: atlas-ph-sensor: Drop GPIO include Linus Walleij
2019-12-07 10:16 ` Jonathan Cameron [this message]
2019-12-07 22:05 ` Matt Ranostay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191207101654.66c807cf@archlinux \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).