linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matt Ranostay <matt.ranostay@konsulko.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [PATCH] iio: atlas-ph-sensor: Drop GPIO include
Date: Sat, 7 Dec 2019 14:05:26 -0800	[thread overview]
Message-ID: <CAJCx=gm-tYWVyudUjhY6eqJnCf9XPmv22MGuDMk=_ct-6nhu6w@mail.gmail.com> (raw)
In-Reply-To: <20191207101654.66c807cf@archlinux>

On Sat, Dec 7, 2019 at 2:16 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Mon,  2 Dec 2019 10:18:37 +0100
> Linus Walleij <linus.walleij@linaro.org> wrote:
>
> > The driver includes <linux/gpio.h> yet fails to use symbols
> > from any the header so drop the include.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> +CC Matt
>
> Applied to the togreg branch of iio.git and pushed out as testing for
> the autobuilders to do something or other.
>

Looks good to me. Probably too late for a Reviewed-by, but here it is anyway

Reviewed-by: Matt Ranostay <matt.ranostay@konsulko.com>

> Thanks,
>
> Jonathan
>
> > ---
> >  drivers/iio/chemical/atlas-ph-sensor.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/iio/chemical/atlas-ph-sensor.c b/drivers/iio/chemical/atlas-ph-sensor.c
> > index 6c175eb1c7a7..b7c20c74239b 100644
> > --- a/drivers/iio/chemical/atlas-ph-sensor.c
> > +++ b/drivers/iio/chemical/atlas-ph-sensor.c
> > @@ -14,7 +14,6 @@
> >  #include <linux/err.h>
> >  #include <linux/irq.h>
> >  #include <linux/irq_work.h>
> > -#include <linux/gpio.h>
> >  #include <linux/i2c.h>
> >  #include <linux/of_device.h>
> >  #include <linux/regmap.h>
>

      reply	other threads:[~2019-12-07 22:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02  9:18 [PATCH] iio: atlas-ph-sensor: Drop GPIO include Linus Walleij
2019-12-07 10:16 ` Jonathan Cameron
2019-12-07 22:05   ` Matt Ranostay [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJCx=gm-tYWVyudUjhY6eqJnCf9XPmv22MGuDMk=_ct-6nhu6w@mail.gmail.com' \
    --to=matt.ranostay@konsulko.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).