* [PATCH] iio: humidity: dht11 remove TODO since it doesn't make sense
@ 2020-01-04 18:19 Kent Gustavsson
2020-01-11 11:55 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Kent Gustavsson @ 2020-01-04 18:19 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Thomas Gleixner, Richard Fontana,
Shobhit Kukreti, Arnd Bergmann, Allison Randal,
Jason A. Donenfeld, Kent Gustavsson
Cc: linux-iio, linux-kernel
DHT11 isn't addressable and will trigger temperature measurement on any
data sent on the bus.
Signed-off-by: Kent Gustavsson <kent@minoris.se>
---
drivers/iio/humidity/dht11.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/humidity/dht11.c b/drivers/iio/humidity/dht11.c
index b459600e1a33..d05c6fdb758b 100644
--- a/drivers/iio/humidity/dht11.c
+++ b/drivers/iio/humidity/dht11.c
@@ -174,7 +174,6 @@ static irqreturn_t dht11_handle_irq(int irq, void *data)
struct iio_dev *iio = data;
struct dht11 *dht11 = iio_priv(iio);
- /* TODO: Consider making the handler safe for IRQ sharing */
if (dht11->num_edges < DHT11_EDGES_PER_READ && dht11->num_edges >= 0) {
dht11->edges[dht11->num_edges].ts = ktime_get_boottime_ns();
dht11->edges[dht11->num_edges++].value =
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: humidity: dht11 remove TODO since it doesn't make sense
2020-01-04 18:19 [PATCH] iio: humidity: dht11 remove TODO since it doesn't make sense Kent Gustavsson
@ 2020-01-11 11:55 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2020-01-11 11:55 UTC (permalink / raw)
To: Kent Gustavsson
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Thomas Gleixner, Richard Fontana, Shobhit Kukreti, Arnd Bergmann,
Allison Randal, Jason A. Donenfeld, linux-iio, linux-kernel
On Sat, 4 Jan 2020 19:19:29 +0100
Kent Gustavsson <kent@minoris.se> wrote:
> DHT11 isn't addressable and will trigger temperature measurement on any
> data sent on the bus.
>
> Signed-off-by: Kent Gustavsson <kent@minoris.se>
Applied.
Thanks,
Jonathan
> ---
> drivers/iio/humidity/dht11.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/humidity/dht11.c b/drivers/iio/humidity/dht11.c
> index b459600e1a33..d05c6fdb758b 100644
> --- a/drivers/iio/humidity/dht11.c
> +++ b/drivers/iio/humidity/dht11.c
> @@ -174,7 +174,6 @@ static irqreturn_t dht11_handle_irq(int irq, void *data)
> struct iio_dev *iio = data;
> struct dht11 *dht11 = iio_priv(iio);
>
> - /* TODO: Consider making the handler safe for IRQ sharing */
> if (dht11->num_edges < DHT11_EDGES_PER_READ && dht11->num_edges >= 0) {
> dht11->edges[dht11->num_edges].ts = ktime_get_boottime_ns();
> dht11->edges[dht11->num_edges++].value =
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-11 11:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-04 18:19 [PATCH] iio: humidity: dht11 remove TODO since it doesn't make sense Kent Gustavsson
2020-01-11 11:55 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).