From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Dylan Howey <Dylan.Howey@tennantco.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: Temperature support for FXLS8471Q accelerometer
Date: Tue, 4 Feb 2020 17:06:22 +0000 [thread overview]
Message-ID: <20200204170622.0000132d@Huawei.com> (raw)
In-Reply-To: <20200204163515.GA25185@tennantco.com>
On Tue, 4 Feb 2020 10:35:17 -0600
Dylan Howey <Dylan.Howey@tennantco.com> wrote:
> Any accel tests I should run before submitting changes? E.g. when I sent
> changes to RTC I ran rtc-test first.
>
We don't have a formal test suite yet. So normally just
check the sysfs files return what you expect + if the driver
supports it, checkout buffered mode using iio_generic_buffer
in tools/iio
Make sure it'll do buffered capture with and without temp
(if that is supported by your patches - often temp is captured
via a different path to other channels, so its fine if not)
Jonathan
> On 01/30/2020 21:35, Lars-Peter Clausen wrote:
> > On 1/29/20 8:32 PM, Dylan Howey wrote:
> > > Hi all,
> > >
> > > The mma8452 driver supports MMA845x, MMA865x and FXLS8471Q devices.
> > >
> > > The FXLS8471Q is unique among these devices in that it has the
> > > additional ability to measure temperature.
> > >
> > > Currently there is no support in mma8452 to measure temperature when
> > > the device is FXLS8471Q. Would anyone be opposed to me adding support?
> > > I have hardware and would be able to test my changes.
> >
> > Hi,
> >
> > Support for new devices is always welcomed :)
> >
> > If you have any questions about the IIO framework let us know.
> >
> > - Lars
> >
>
prev parent reply other threads:[~2020-02-04 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 19:32 Temperature support for FXLS8471Q accelerometer Dylan Howey
2020-01-30 20:35 ` Lars-Peter Clausen
2020-02-04 16:35 ` Dylan Howey
2020-02-04 17:06 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204170622.0000132d@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=Dylan.Howey@tennantco.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).