[PATCH 1/3] dt-bindings: iio: dac: ad5770r: Add vendor to compatible string

[PATCH 1/3] dt-bindings: iio: dac: ad5770r: Add vendor to compatible string

[Fabio Estevam]

The compatible string in the example misses the vendor information.

Pass the "adi" vendor to fix it.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
index d9c25cf4b92f..f937040477ec 100644
--- a/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
@@ -144,7 +144,7 @@ examples:
                 #size-cells = <0>;
 
                 ad5770r@0 {
-                        compatible = "ad5770r";
+                        compatible = "adi,ad5770r";
                         reg = <0>;
                         spi-max-frequency = <1000000>;
                         vref-supply = <&vref>;
-- 
2.17.1

[PATCH 2/3] dt-bindings: iio: dac: ad5770r: Remove unneeded unit names

[Fabio Estevam]

The following warnings are seen with 'make dt_binding_check':

Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:29.35-32.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@0: node has a unit name, but no reg or ranges property
Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:34.35-37.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@1: node has a unit name, but no reg or ranges property
Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:39.35-42.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@2: node has a unit name, but no reg or ranges property
Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:44.35-47.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@3: node has a unit name, but no reg or ranges property
Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:49.35-52.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@4: node has a unit name, but no reg or ranges property
Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:54.35-57.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@5: node has a unit name, but no reg or ranges property

Fix them by removing the unneeded unit addresses.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 .../devicetree/bindings/iio/dac/adi,ad5770r.yaml     | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
index f937040477ec..fa86ef52b121 100644
--- a/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
@@ -151,32 +151,32 @@ examples:
                         adi,external-resistor;
                         reset-gpios = <&gpio 22 0>;
 
-                        channel@0 {
+                        channel0 {
                                 num = <0>;
                                 adi,range-microamp = <(-60000) 300000>;
                         };
 
-                        channel@1 {
+                        channel1 {
                                 num = <1>;
                                 adi,range-microamp = <0 140000>;
                         };
 
-                        channel@2 {
+                        channel2 {
                                 num = <2>;
                                 adi,range-microamp = <0 55000>;
                         };
 
-                        channel@3 {
+                        channel3 {
                                 num = <3>;
                                 adi,range-microamp = <0 45000>;
                         };
 
-                        channel@4 {
+                        channel4 {
                                 num = <4>;
                                 adi,range-microamp = <0 45000>;
                         };
 
-                        channel@5 {
+                        channel5 {
                                 num = <5>;
                                 adi,range-microamp = <0 45000>;
                         };
-- 
2.17.1

Re: [PATCH 2/3] dt-bindings: iio: dac: ad5770r: Remove unneeded unit names

[Rob Herring]

On Fri, Mar 27, 2020 at 7:18 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> The following warnings are seen with 'make dt_binding_check':
>
> Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:29.35-32.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@0: node has a unit name, but no reg or ranges property
> Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:34.35-37.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@1: node has a unit name, but no reg or ranges property
> Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:39.35-42.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@2: node has a unit name, but no reg or ranges property
> Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:44.35-47.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@3: node has a unit name, but no reg or ranges property
> Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:49.35-52.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@4: node has a unit name, but no reg or ranges property
> Documentation/devicetree/bindings/iio/dac/adi,ad5770r.example.dts:54.35-57.27: Warning (unit_address_vs_reg): /example-0/spi/ad5770r@0/channel@5: node has a unit name, but no reg or ranges property
>
> Fix them by removing the unneeded unit addresses.

Actually, we want to use 'reg' instead of 'num'. Alexandru is
attempting to fix[1].

But looks like you found another issue with patch 1.

Rob

[1] https://lore.kernel.org/linux-iio/CAL_JsqKFdcACQtXd5h=4Pxbij+=uoHr2rLTFZMq4fVX8ph398g@mail.gmail.com/

[PATCH 3/3] dt-bindings: iio: dac: ad5770r: Fix the file path

[Fabio Estevam]

The following warning is seen with 'make dt_binding_check':

Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml: $id: relative path/filename doesn't match actual path or filename

Fix it by removing the "bindings" directory from the file path.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
index fa86ef52b121..5661d62b994f 100644
--- a/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
@@ -2,7 +2,7 @@
 # Copyright 2020 Analog Devices Inc.
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/bindings/iio/dac/adi,ad5770r.yaml#
+$id: http://devicetree.org/schemas/iio/dac/adi,ad5770r.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Analog Devices AD5770R DAC device driver
-- 
2.17.1

Re: [PATCH 3/3] dt-bindings: iio: dac: ad5770r: Fix the file path

[Rob Herring]

On Fri, 27 Mar 2020 10:18:25 -0300, Fabio Estevam wrote:
> The following warning is seen with 'make dt_binding_check':
> 
> Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml: $id: relative path/filename doesn't match actual path or filename
> 
> Fix it by removing the "bindings" directory from the file path.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks.

Rob

Re: [PATCH 1/3] dt-bindings: iio: dac: ad5770r: Add vendor to compatible string

[Rob Herring]

On Fri, Mar 27, 2020 at 7:18 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> The compatible string in the example misses the vendor information.
>
> Pass the "adi" vendor to fix it.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH 1/3] dt-bindings: iio: dac: ad5770r: Add vendor to compatible string

[Rob Herring]

On Fri, 27 Mar 2020 10:18:23 -0300, Fabio Estevam wrote:
> The compatible string in the example misses the vendor information.
> 
> Pass the "adi" vendor to fix it.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks.

Rob