* [PATCH] iio: st_sensors: rely on odr mask to know if odr can be set
@ 2020-04-11 15:16 yarl-baudig
2020-04-12 9:49 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: yarl-baudig @ 2020-04-11 15:16 UTC (permalink / raw)
To: linux-iio
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Denis Ciocca
Indeed, relying on addr being not 0 cannot work because some device have
their register to set odr at address 0. As a matter of fact, if the odr
can be set, then there is a mask.
Sensors with ODR register at address 0 are: lsm303dlh, lsm303dlhc, lsm303dlm
Fixes: 7d245172675a ("iio: common: st_sensors: check odr address value in st_sensors_set_odr()")
Signed-off-by: Lary Gibaud <yarl-baudig@mailoo.org>
---
drivers/iio/common/st_sensors/st_sensors_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/iio/common/st_sensors/st_sensors_core.c
index a0c2cbd60c6f..cccd4c26dfa4 100644
--- a/drivers/iio/common/st_sensors/st_sensors_core.c
+++ b/drivers/iio/common/st_sensors/st_sensors_core.c
@@ -79,7 +79,7 @@ int st_sensors_set_odr(struct iio_dev *indio_dev, unsigned int odr)
struct st_sensor_odr_avl odr_out = {0, 0};
struct st_sensor_data *sdata = iio_priv(indio_dev);
- if (!sdata->sensor_settings->odr.addr)
+ if (!sdata->sensor_settings->odr.mask)
return 0;
err = st_sensors_match_odr(sdata->sensor_settings, odr, &odr_out);
--
2.26.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] iio: st_sensors: rely on odr mask to know if odr can be set
2020-04-11 15:16 [PATCH] iio: st_sensors: rely on odr mask to know if odr can be set yarl-baudig
@ 2020-04-12 9:49 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2020-04-12 9:49 UTC (permalink / raw)
To: yarl-baudig
Cc: linux-iio, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Denis Ciocca
On Sat, 11 Apr 2020 17:16:06 +0200 (CEST)
yarl-baudig@mailoo.org wrote:
> Indeed, relying on addr being not 0 cannot work because some device have
> their register to set odr at address 0. As a matter of fact, if the odr
> can be set, then there is a mask.
>
> Sensors with ODR register at address 0 are: lsm303dlh, lsm303dlhc, lsm303dlm
>
> Fixes: 7d245172675a ("iio: common: st_sensors: check odr address value in st_sensors_set_odr()")
> Signed-off-by: Lary Gibaud <yarl-baudig@mailoo.org>
Applied to the fixes-togreg branch of iio.git and marked for
stable.
Thanks,
Jonathan
> ---
> drivers/iio/common/st_sensors/st_sensors_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/iio/common/st_sensors/st_sensors_core.c
> index a0c2cbd60c6f..cccd4c26dfa4 100644
> --- a/drivers/iio/common/st_sensors/st_sensors_core.c
> +++ b/drivers/iio/common/st_sensors/st_sensors_core.c
> @@ -79,7 +79,7 @@ int st_sensors_set_odr(struct iio_dev *indio_dev, unsigned int odr)
> struct st_sensor_odr_avl odr_out = {0, 0};
> struct st_sensor_data *sdata = iio_priv(indio_dev);
>
> - if (!sdata->sensor_settings->odr.addr)
> + if (!sdata->sensor_settings->odr.mask)
> return 0;
>
> err = st_sensors_match_odr(sdata->sensor_settings, odr, &odr_out);
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] iio: st_sensors: rely on odr mask to know if odr can be set
@ 2020-04-02 13:40 yarl-baudig
2020-04-05 11:57 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: yarl-baudig @ 2020-04-02 13:40 UTC (permalink / raw)
To: linux-iio
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Denis Ciocca
Indeed, relying on addr being not 0 cannot work because some device have
their register to set odr at address 0. As a matter of fact, if the odr
can be set, then there is a mask.
Signed-off-by: Lary Gibaud <yarl-baudig@mailoo.org>
---
drivers/iio/common/st_sensors/st_sensors_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/iio/common/st_sensors/st_sensors_core.c
index a0c2cbd60c6f..cccd4c26dfa4 100644
--- a/drivers/iio/common/st_sensors/st_sensors_core.c
+++ b/drivers/iio/common/st_sensors/st_sensors_core.c
@@ -79,7 +79,7 @@ int st_sensors_set_odr(struct iio_dev *indio_dev, unsigned int odr)
struct st_sensor_odr_avl odr_out = {0, 0};
struct st_sensor_data *sdata = iio_priv(indio_dev);
- if (!sdata->sensor_settings->odr.addr)
+ if (!sdata->sensor_settings->odr.mask)
return 0;
err = st_sensors_match_odr(sdata->sensor_settings, odr, &odr_out);
--
2.26.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] iio: st_sensors: rely on odr mask to know if odr can be set
2020-04-02 13:40 yarl-baudig
@ 2020-04-05 11:57 ` Jonathan Cameron
2020-04-09 11:24 ` yarl-baudig
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Cameron @ 2020-04-05 11:57 UTC (permalink / raw)
To: yarl-baudig
Cc: linux-iio, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Denis Ciocca
On Thu, 2 Apr 2020 15:40:59 +0200 (CEST)
yarl-baudig@mailoo.org wrote:
> Indeed, relying on addr being not 0 cannot work because some device have
> their register to set odr at address 0. As a matter of fact, if the odr
> can be set, then there is a mask.
Hi Lary,
Which sensor has ODR in the register at address 0?
I see it's a few of the magnetometers from a quick grep, but please state
it in the cover letter. Also please add a suitable Fixes tag
as we will want this backported if appropriate.
Thanks,
Jonathan
>
> Signed-off-by: Lary Gibaud <yarl-baudig@mailoo.org>
> ---
> drivers/iio/common/st_sensors/st_sensors_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/iio/common/st_sensors/st_sensors_core.c
> index a0c2cbd60c6f..cccd4c26dfa4 100644
> --- a/drivers/iio/common/st_sensors/st_sensors_core.c
> +++ b/drivers/iio/common/st_sensors/st_sensors_core.c
> @@ -79,7 +79,7 @@ int st_sensors_set_odr(struct iio_dev *indio_dev, unsigned int odr)
> struct st_sensor_odr_avl odr_out = {0, 0};
> struct st_sensor_data *sdata = iio_priv(indio_dev);
>
> - if (!sdata->sensor_settings->odr.addr)
> + if (!sdata->sensor_settings->odr.mask)
> return 0;
>
> err = st_sensors_match_odr(sdata->sensor_settings, odr, &odr_out);
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] iio: st_sensors: rely on odr mask to know if odr can be set
2020-04-05 11:57 ` Jonathan Cameron
@ 2020-04-09 11:24 ` yarl-baudig
0 siblings, 0 replies; 6+ messages in thread
From: yarl-baudig @ 2020-04-09 11:24 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linux-iio, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Denis Ciocca
Oh, sorry, just saw your answer. Ok I can list such sensors.
Please tell me what I should do about Fixes tag. That's the first time I send a patch I'm not sure What I should put in it.
Is it :
Fixes: 4358be137952 (MAINTAINERS: Add Syed Nayyar Waris to ACCES 104-QUAD-8 driver)
? Thank you.
---- Message d'origine ----
> De : Jonathan Cameron <jic23@kernel.org>
> À : yarl-baudig@mailoo.org
> Sujet : Re: [PATCH] iio: st_sensors: rely on odr mask to know if odr can be set
> Date : 05/04/2020 13:57:02 Europe/Paris
> Copie à : linux-iio@vger.kernel.org;
> Hartmut Knaack <knaack.h@gmx.de>;
> Lars-Peter Clausen <lars@metafoo.de>;
> Peter Meerwald-Stadler <pmeerw@pmeerw.net>;
> Denis Ciocca <denis.ciocca@st.com>
>
> On Thu, 2 Apr 2020 15:40:59 +0200 (CEST)
> yarl-baudig@mailoo.org wrote:
>
> > Indeed, relying on addr being not 0 cannot work because some device have
> > their register to set odr at address 0. As a matter of fact, if the odr
> > can be set, then there is a mask.
>
> Hi Lary,
>
> Which sensor has ODR in the register at address 0?
>
> I see it's a few of the magnetometers from a quick grep, but please state
> it in the cover letter. Also please add a suitable Fixes tag
> as we will want this backported if appropriate.
>
> Thanks,
>
> Jonathan
>
> >
> > Signed-off-by: Lary Gibaud <yarl-baudig@mailoo.org>
> > ---
> > drivers/iio/common/st_sensors/st_sensors_core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c
> b/drivers/iio/common/st_sensors/st_sensors_core.c
> > index a0c2cbd60c6f..cccd4c26dfa4 100644
> > --- a/drivers/iio/common/st_sensors/st_sensors_core.c
> > +++ b/drivers/iio/common/st_sensors/st_sensors_core.c
> > @@ -79,7 +79,7 @@ int st_sensors_set_odr(struct iio_dev *indio_dev,
> unsigned int odr)
> > struct st_sensor_odr_avl odr_out = {0, 0};
> > struct st_sensor_data *sdata = iio_priv(indio_dev);
> >
> > - if (!sdata->sensor_settings->odr.addr)
> > + if (!sdata->sensor_settings->odr.mask)
> > return 0;
> >
> > err = st_sensors_match_odr(sdata->sensor_settings, odr, &odr_out);
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] iio: st_sensors: rely on odr mask to know if odr can be set
@ 2020-04-02 13:08 yarl-baudig
0 siblings, 0 replies; 6+ messages in thread
From: yarl-baudig @ 2020-04-02 13:08 UTC (permalink / raw)
To: linux-iio
Indeed, relying on addr being not 0 cannot work because some device have
their register to set odr at address 0. As a matter of fact, if the odr
can be set, then there is a mask.
---
drivers/iio/common/st_sensors/st_sensors_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/iio/common/st_sensors/st_sensors_core.c
index a0c2cbd60c6f..cccd4c26dfa4 100644
--- a/drivers/iio/common/st_sensors/st_sensors_core.c
+++ b/drivers/iio/common/st_sensors/st_sensors_core.c
@@ -79,7 +79,7 @@ int st_sensors_set_odr(struct iio_dev *indio_dev, unsigned int odr)
struct st_sensor_odr_avl odr_out = {0, 0};
struct st_sensor_data *sdata = iio_priv(indio_dev);
- if (!sdata->sensor_settings->odr.addr)
+ if (!sdata->sensor_settings->odr.mask)
return 0;
err = st_sensors_match_odr(sdata->sensor_settings, odr, &odr_out);
--
2.26.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-12 9:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-11 15:16 [PATCH] iio: st_sensors: rely on odr mask to know if odr can be set yarl-baudig
2020-04-12 9:49 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2020-04-02 13:40 yarl-baudig
2020-04-05 11:57 ` Jonathan Cameron
2020-04-09 11:24 ` yarl-baudig
2020-04-02 13:08 yarl-baudig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).