From: Manivannan Sadhasivam <mani@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: robh+dt@kernel.org, narcisaanamaria12@gmail.com, knaack.h@gmx.de,
lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] iio: chemical: Add OF match table for CCS811 VOC sensor
Date: Tue, 14 Apr 2020 17:21:53 +0530 [thread overview]
Message-ID: <20200414115153.GC21559@Mani-XPS-13-9360> (raw)
In-Reply-To: <20200413175054.626283dc@archlinux>
On Mon, Apr 13, 2020 at 05:50:54PM +0100, Jonathan Cameron wrote:
> On Mon, 13 Apr 2020 00:06:58 +0530
> mani@kernel.org wrote:
>
> > From: Manivannan Sadhasivam <mani@kernel.org>
> >
> > Add devicetree OF match table support for CCS811 VOC sensor.
> >
> > Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
>
> Hi,
>
> A few small things to clean up inline
>
> Thanks,
>
> Jonathan
>
> > ---
> > drivers/iio/chemical/ccs811.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/iio/chemical/ccs811.c b/drivers/iio/chemical/ccs811.c
> > index 6cd92c49c348..313931208f61 100644
> > --- a/drivers/iio/chemical/ccs811.c
> > +++ b/drivers/iio/chemical/ccs811.c
> > @@ -24,6 +24,7 @@
> > #include <linux/iio/triggered_buffer.h>
> > #include <linux/iio/trigger_consumer.h>
> > #include <linux/module.h>
> > +#include <linux/of.h>
>
> You are including this just to get things in mod_devicetable.h
> so include that directly instead.
>
I added this include for of_match_ptr. Since it is not needed anymore, I'll drop
this.
> >
> > #define CCS811_STATUS 0x00
> > #define CCS811_MEAS_MODE 0x01
> > @@ -538,9 +539,16 @@ static const struct i2c_device_id ccs811_id[] = {
> > };
> > MODULE_DEVICE_TABLE(i2c, ccs811_id);
> >
> > +static const struct of_device_id ccs811_dt_ids[] = {
> > + { .compatible = "ams,ccs811" },
> > + { }
> > +};
> > +MODULE_DEVICE_TABLE(of, ccs811_dt_ids);
> > +
> > static struct i2c_driver ccs811_driver = {
> > .driver = {
> > .name = "ccs811",
> > + .of_match_table = of_match_ptr(ccs811_dt_ids),
> No need for the of_match_ptr macro. It has several issues.
>
> 1) Blocks PRP001 ACPI magic device types being used to instantiate
> this using the device tree binding but under ACPI.
> 2) Will give warnings about ccs811_dt_ids being unused on no
> device tree builds.
>
Okay, will use ccs811_dt_ids directly.
Thanks,
Mani
> > },
> > .probe = ccs811_probe,
> > .remove = ccs811_remove,
>
next prev parent reply other threads:[~2020-04-14 11:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 18:36 [PATCH 0/3] Add Reset and Wakeup support for CCS811 mani
2020-04-12 18:36 ` [PATCH 1/3] dt-bindings: iio: chemical: Add binding for CCS811 VOC sensor mani
2020-04-13 16:53 ` Jonathan Cameron
2020-04-14 12:10 ` Manivannan Sadhasivam
2020-04-14 13:27 ` Rob Herring
2020-04-14 14:08 ` Manivannan Sadhasivam
2020-04-12 18:36 ` [PATCH 2/3] iio: chemical: Add support for external Reset and Wakeup in CCS811 mani
2020-04-13 16:58 ` Jonathan Cameron
2020-04-13 20:20 ` Andy Shevchenko
2020-04-14 12:08 ` Manivannan Sadhasivam
2020-04-12 18:36 ` [PATCH 3/3] iio: chemical: Add OF match table for CCS811 VOC sensor mani
2020-04-13 16:50 ` Jonathan Cameron
2020-04-14 11:51 ` Manivannan Sadhasivam [this message]
2020-04-13 20:23 ` Andy Shevchenko
2020-04-14 11:53 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414115153.GC21559@Mani-XPS-13-9360 \
--to=mani@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narcisaanamaria12@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).