From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: mani@kernel.org
Cc: Jonathan Cameron <jic23@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
narcisaanamaria12@gmail.com, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
linux-iio <linux-iio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] iio: chemical: Add OF match table for CCS811 VOC sensor
Date: Mon, 13 Apr 2020 23:23:03 +0300 [thread overview]
Message-ID: <CAHp75VeHctOu7+o6nMsqNU7q7gcJnK=n=dPX3xVMSgR9PsWjAA@mail.gmail.com> (raw)
In-Reply-To: <20200412183658.6755-4-mani@kernel.org>
On Mon, Apr 13, 2020 at 10:23 AM <mani@kernel.org> wrote:
>
> From: Manivannan Sadhasivam <mani@kernel.org>
>
> Add devicetree OF match table support for CCS811 VOC sensor.
...
> +#include <linux/of.h>
Why?
...
> +static const struct of_device_id ccs811_dt_ids[] = {
> + { .compatible = "ams,ccs811" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, ccs811_dt_ids);
Since it has no ugly ifdeffery...
> static struct i2c_driver ccs811_driver = {
> .driver = {
> .name = "ccs811",
> + .of_match_table = of_match_ptr(ccs811_dt_ids),
...use of of_match_ptr() brings a compiler warning.
Drop of_match_ptr() for good. And thus drop redundant of.h.
> },
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-04-13 20:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 18:36 [PATCH 0/3] Add Reset and Wakeup support for CCS811 mani
2020-04-12 18:36 ` [PATCH 1/3] dt-bindings: iio: chemical: Add binding for CCS811 VOC sensor mani
2020-04-13 16:53 ` Jonathan Cameron
2020-04-14 12:10 ` Manivannan Sadhasivam
2020-04-14 13:27 ` Rob Herring
2020-04-14 14:08 ` Manivannan Sadhasivam
2020-04-12 18:36 ` [PATCH 2/3] iio: chemical: Add support for external Reset and Wakeup in CCS811 mani
2020-04-13 16:58 ` Jonathan Cameron
2020-04-13 20:20 ` Andy Shevchenko
2020-04-14 12:08 ` Manivannan Sadhasivam
2020-04-12 18:36 ` [PATCH 3/3] iio: chemical: Add OF match table for CCS811 VOC sensor mani
2020-04-13 16:50 ` Jonathan Cameron
2020-04-14 11:51 ` Manivannan Sadhasivam
2020-04-13 20:23 ` Andy Shevchenko [this message]
2020-04-14 11:53 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VeHctOu7+o6nMsqNU7q7gcJnK=n=dPX3xVMSgR9PsWjAA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=narcisaanamaria12@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).