From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: bmc150_magn: Document and fix missing compatibles
Date: Sat, 27 Jun 2020 14:43:59 +0100 [thread overview]
Message-ID: <20200627144359.1ae30bb0@archlinux> (raw)
In-Reply-To: <20200622060110.23192-1-krzk@kernel.org>
On Mon, 22 Jun 2020 08:01:09 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> The driver supports also BMC156B and BMM150B but these compatibles had
> redundant suffix "_magn". Add existing compatibles marking them
> deprecated along with adding a new, proper one for this family of
> devices.
Thanks for tidying this up.
The BMC156B is a dual magnetometer and accelerometer chip
so for that one the _magn postfix probably is needed.
Or am I missing something?
The way this does SPI is rather odd but seems to be the same as the bmc150
(two chips with non overlapping register maps).
Jonathan
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Changes since v1:
> 1. Mark old compatibles as deprecated, add new one.
> ---
> .../devicetree/bindings/iio/magnetometer/bmc150_magn.txt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt b/Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt
> index fd5fca90fb39..efeda055be6a 100644
> --- a/Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt
> +++ b/Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt
> @@ -4,7 +4,11 @@ http://ae-bst.resource.bosch.com/media/products/dokumente/bmc150/BST-BMC150-DS00
>
> Required properties:
>
> - - compatible : should be "bosch,bmc150_magn"
> + - compatible : should be one of:
> + "bosch,bmc150_magn"
> + "bosch,bmc156"
> + "bosch,bmc156_magn" (DEPRECATED, use bosch,bmc156)
> + "bosch,bmm150_magn" (DEPRECATED, use bosch,bmc156)
> - reg : the I2C address of the magnetometer
>
> Optional properties:
next prev parent reply other threads:[~2020-06-27 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 6:01 [PATCH v2 1/2] dt-bindings: iio: bmc150_magn: Document and fix missing compatibles Krzysztof Kozlowski
2020-06-22 6:01 ` [PATCH v2 2/2] iio: magnetometer: bmc150: Add proper compatible BMC156 and BMM150 Krzysztof Kozlowski
2020-06-27 13:43 ` Jonathan Cameron [this message]
2020-06-29 6:52 ` [PATCH v2 1/2] dt-bindings: iio: bmc150_magn: Document and fix missing compatibles Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200627144359.1ae30bb0@archlinux \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).