From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: bmc150_magn: Document and fix missing compatibles
Date: Mon, 29 Jun 2020 08:52:10 +0200 [thread overview]
Message-ID: <20200629065210.GB5879@kozik-lap> (raw)
In-Reply-To: <20200627144359.1ae30bb0@archlinux>
On Sat, Jun 27, 2020 at 02:43:59PM +0100, Jonathan Cameron wrote:
> On Mon, 22 Jun 2020 08:01:09 +0200
> Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> > The driver supports also BMC156B and BMM150B but these compatibles had
> > redundant suffix "_magn". Add existing compatibles marking them
> > deprecated along with adding a new, proper one for this family of
> > devices.
> Thanks for tidying this up.
>
> The BMC156B is a dual magnetometer and accelerometer chip
> so for that one the _magn postfix probably is needed.
>
> Or am I missing something?
>
> The way this does SPI is rather odd but seems to be the same as the bmc150
> (two chips with non overlapping register maps).
You're right, only one compatible should be trimmed from suffix. I'll
send v3.
Best regards,
Krzysztof
prev parent reply other threads:[~2020-06-29 20:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 6:01 [PATCH v2 1/2] dt-bindings: iio: bmc150_magn: Document and fix missing compatibles Krzysztof Kozlowski
2020-06-22 6:01 ` [PATCH v2 2/2] iio: magnetometer: bmc150: Add proper compatible BMC156 and BMM150 Krzysztof Kozlowski
2020-06-27 13:43 ` [PATCH v2 1/2] dt-bindings: iio: bmc150_magn: Document and fix missing compatibles Jonathan Cameron
2020-06-29 6:52 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629065210.GB5879@kozik-lap \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).