* [PATCH v3 1/2] dt-bindings: iio: bmc150_magn: Document and fix missing compatibles
@ 2020-06-29 10:05 Krzysztof Kozlowski
2020-06-29 10:05 ` [PATCH v3 2/2] iio: magnetometer: bmc150: Add proper compatible for BMM150 Krzysztof Kozlowski
2020-07-13 19:05 ` [PATCH v3 1/2] dt-bindings: iio: bmc150_magn: Document and fix missing compatibles Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2020-06-29 10:05 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Rob Herring, Krzysztof Kozlowski,
linux-iio, devicetree, linux-kernel
The driver supports also BMC156B and BMM150B. Add existing compatibles
marking the BMM150B one as deprecated (due to redundant suffix "_magn"
because the device unlike two others is a magnetometer only). Introduce
a new, proper compatible for the deprecated one.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Changes since v2:
1. Add compatible only for bmm150.
Changes since v1:
1. Mark old compatibles as deprecated, add new one.
---
.../devicetree/bindings/iio/magnetometer/bmc150_magn.txt | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt b/Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt
index fd5fca90fb39..22912e43b60c 100644
--- a/Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt
+++ b/Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt
@@ -4,7 +4,11 @@ http://ae-bst.resource.bosch.com/media/products/dokumente/bmc150/BST-BMC150-DS00
Required properties:
- - compatible : should be "bosch,bmc150_magn"
+ - compatible : should be one of:
+ "bosch,bmc150_magn"
+ "bosch,bmc156_magn"
+ "bosch,bmm150"
+ "bosch,bmm150_magn" (DEPRECATED, use bosch,bmm150)
- reg : the I2C address of the magnetometer
Optional properties:
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v3 2/2] iio: magnetometer: bmc150: Add proper compatible for BMM150
2020-06-29 10:05 [PATCH v3 1/2] dt-bindings: iio: bmc150_magn: Document and fix missing compatibles Krzysztof Kozlowski
@ 2020-06-29 10:05 ` Krzysztof Kozlowski
2020-07-04 16:46 ` Jonathan Cameron
2020-07-13 19:05 ` [PATCH v3 1/2] dt-bindings: iio: bmc150_magn: Document and fix missing compatibles Rob Herring
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2020-06-29 10:05 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Rob Herring, Krzysztof Kozlowski,
linux-iio, devicetree, linux-kernel
The compatible for BMM150 should not have "_magn" suffix because, unlike
two other Bosch devices, it is only a magnetometer.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Changes since v2:
1. Add compatible only for bmm150.
Changes since v1:
1. New patch.
---
drivers/iio/magnetometer/bmc150_magn_i2c.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/magnetometer/bmc150_magn_i2c.c b/drivers/iio/magnetometer/bmc150_magn_i2c.c
index fb45b63c56e4..876e96005e33 100644
--- a/drivers/iio/magnetometer/bmc150_magn_i2c.c
+++ b/drivers/iio/magnetometer/bmc150_magn_i2c.c
@@ -58,7 +58,8 @@ MODULE_DEVICE_TABLE(i2c, bmc150_magn_i2c_id);
static const struct of_device_id bmc150_magn_of_match[] = {
{ .compatible = "bosch,bmc150_magn" },
{ .compatible = "bosch,bmc156_magn" },
- { .compatible = "bosch,bmm150_magn" },
+ { .compatible = "bosch,bmm150_magn" }, /* deprecated compatible */
+ { .compatible = "bosch,bmm150" },
{ }
};
MODULE_DEVICE_TABLE(of, bmc150_magn_of_match);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3 2/2] iio: magnetometer: bmc150: Add proper compatible for BMM150
2020-06-29 10:05 ` [PATCH v3 2/2] iio: magnetometer: bmc150: Add proper compatible for BMM150 Krzysztof Kozlowski
@ 2020-07-04 16:46 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2020-07-04 16:46 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Rob Herring, linux-iio, devicetree, linux-kernel
On Mon, 29 Jun 2020 12:05:37 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> The compatible for BMM150 should not have "_magn" suffix because, unlike
> two other Bosch devices, it is only a magnetometer.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Both applied to the togreg branch of iio.git and pushed out
as testing for the autobuilders to ignore them.
Thanks for tidying this up.
Jonathan
>
> ---
>
> Changes since v2:
> 1. Add compatible only for bmm150.
>
> Changes since v1:
> 1. New patch.
> ---
> drivers/iio/magnetometer/bmc150_magn_i2c.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/magnetometer/bmc150_magn_i2c.c b/drivers/iio/magnetometer/bmc150_magn_i2c.c
> index fb45b63c56e4..876e96005e33 100644
> --- a/drivers/iio/magnetometer/bmc150_magn_i2c.c
> +++ b/drivers/iio/magnetometer/bmc150_magn_i2c.c
> @@ -58,7 +58,8 @@ MODULE_DEVICE_TABLE(i2c, bmc150_magn_i2c_id);
> static const struct of_device_id bmc150_magn_of_match[] = {
> { .compatible = "bosch,bmc150_magn" },
> { .compatible = "bosch,bmc156_magn" },
> - { .compatible = "bosch,bmm150_magn" },
> + { .compatible = "bosch,bmm150_magn" }, /* deprecated compatible */
> + { .compatible = "bosch,bmm150" },
> { }
> };
> MODULE_DEVICE_TABLE(of, bmc150_magn_of_match);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: iio: bmc150_magn: Document and fix missing compatibles
2020-06-29 10:05 [PATCH v3 1/2] dt-bindings: iio: bmc150_magn: Document and fix missing compatibles Krzysztof Kozlowski
2020-06-29 10:05 ` [PATCH v3 2/2] iio: magnetometer: bmc150: Add proper compatible for BMM150 Krzysztof Kozlowski
@ 2020-07-13 19:05 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2020-07-13 19:05 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-iio, Jonathan Cameron, Lars-Peter Clausen,
Peter Meerwald-Stadler, Hartmut Knaack, linux-kernel,
Rob Herring, devicetree
On Mon, 29 Jun 2020 12:05:36 +0200, Krzysztof Kozlowski wrote:
> The driver supports also BMC156B and BMM150B. Add existing compatibles
> marking the BMM150B one as deprecated (due to redundant suffix "_magn"
> because the device unlike two others is a magnetometer only). Introduce
> a new, proper compatible for the deprecated one.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Changes since v2:
> 1. Add compatible only for bmm150.
>
> Changes since v1:
> 1. Mark old compatibles as deprecated, add new one.
> ---
> .../devicetree/bindings/iio/magnetometer/bmc150_magn.txt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-13 19:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-29 10:05 [PATCH v3 1/2] dt-bindings: iio: bmc150_magn: Document and fix missing compatibles Krzysztof Kozlowski
2020-06-29 10:05 ` [PATCH v3 2/2] iio: magnetometer: bmc150: Add proper compatible for BMM150 Krzysztof Kozlowski
2020-07-04 16:46 ` Jonathan Cameron
2020-07-13 19:05 ` [PATCH v3 1/2] dt-bindings: iio: bmc150_magn: Document and fix missing compatibles Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).