From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Matt Ranostay" <matt.ranostay@konsulko.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Alexandru Ardelean" <alexandru.ardelean@analog.com>
Subject: Re: IIO: Review request.
Date: Fri, 18 Sep 2020 16:05:06 +0100 [thread overview]
Message-ID: <20200918160506.00001e9d@huawei.com> (raw)
In-Reply-To: <CAHp75VfEAA7QeFz1uEVoX6fsuO9kGEmLTCZkHaCk8_rOWigtbQ@mail.gmail.com>
On Fri, 18 Sep 2020 17:05:29 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Fri, Sep 18, 2020 at 3:34 PM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > Hi All,
> >
> > Classic being the maintainer problem, is that there is no one specific to pester
> > when you can't get reviews on your own patches. Hence if anyone has some
> > time I'd appreciate sanity checks on:
> >
> > [PATCH 2/3] iio: Add __printf() attributes to various allocation functions
> > https://lore.kernel.org/linux-iio/20200913132115.800131-3-jic23@kernel.org/
> >
>
> Examples show that rather
> static __printf() for the first occurrence. Otherwise the entire list
> of these patches LGTM. You may put my Rb tag.
Thanks to everyone who jumped on these.
I'll fix up that and pick them up shortly.
Jonathan
>
> > [PATCH 3/3] iio:core: Tidy up kernel-doc.
> > https://lore.kernel.org/linux-iio/20200913132115.800131-4-jic23@kernel.org/
> >
> > [PATCH] iio:magn:hmc5843: Fix passing true where iio_shared_by enum required.
> > https://lore.kernel.org/linux-iio/20200913112546.715624-1-jic23@kernel.org/
> >
> > [PATCH] iio:accel:bma180: Fix use of true when should be iio_shared_by enum
> > https://lore.kernel.org/linux-iio/20200913121227.764626-1-jic23@kernel.org/
> >
> > For those last 2 I forgot I'd previously sent effectively the same fixes out
> > earlier in the year but didn't get any reviews then either :(
> >
> > Note I've randomly picked a few people who have done reviews or posted a lot
> > of patches recently for the cc list. I'm more than happy if anyone else
> > wants to join in with the fun :) Reviews are always appreciated for any
> > code submitted to IIO from anyone. If you are unsure about something in
> > a review, it is fine to say so. Hence even relatively new people can
> > offer great value. We all started somewhere!
> >
> > Thanks,
> >
> > Jonathan
>
>
>
prev parent reply other threads:[~2020-09-18 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 12:33 IIO: Review request Jonathan Cameron
2020-09-18 14:05 ` Andy Shevchenko
2020-09-18 15:05 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918160506.00001e9d@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alexandru.ardelean@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).