IIO: Review request.

IIO: Review request.

[Jonathan Cameron]

Hi All,

Classic being the maintainer problem, is that there is no one specific to pester
when you can't get reviews on your own patches.  Hence if anyone has some
time I'd appreciate sanity checks on:

[PATCH 2/3] iio: Add __printf() attributes to various allocation functions
https://lore.kernel.org/linux-iio/20200913132115.800131-3-jic23@kernel.org/

[PATCH 3/3] iio:core: Tidy up kernel-doc.
https://lore.kernel.org/linux-iio/20200913132115.800131-4-jic23@kernel.org/

[PATCH] iio:magn:hmc5843: Fix passing true where iio_shared_by enum required.
https://lore.kernel.org/linux-iio/20200913112546.715624-1-jic23@kernel.org/

[PATCH] iio:accel:bma180: Fix use of true when should be iio_shared_by enum
https://lore.kernel.org/linux-iio/20200913121227.764626-1-jic23@kernel.org/

For those last 2 I forgot I'd previously sent effectively the same fixes out
earlier in the year but didn't get any reviews then either :(

Note I've randomly picked a few people who have done reviews or posted a lot
of patches recently for the cc list.  I'm more than happy if anyone else
wants to join in with the fun :)  Reviews are always appreciated for any
code submitted to IIO from anyone.  If you are unsure about something in
a review, it is fine to say so.  Hence even relatively new people can
offer great value.  We all started somewhere!

Thanks,

Jonathan

Re: IIO: Review request.

[Andy Shevchenko]

On Fri, Sep 18, 2020 at 3:34 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> Hi All,
>
> Classic being the maintainer problem, is that there is no one specific to pester
> when you can't get reviews on your own patches.  Hence if anyone has some
> time I'd appreciate sanity checks on:
>
> [PATCH 2/3] iio: Add __printf() attributes to various allocation functions
> https://lore.kernel.org/linux-iio/20200913132115.800131-3-jic23@kernel.org/
>

Examples show that rather
static __printf() for the first occurrence. Otherwise the entire list
of these patches LGTM. You may put my Rb tag.

> [PATCH 3/3] iio:core: Tidy up kernel-doc.
> https://lore.kernel.org/linux-iio/20200913132115.800131-4-jic23@kernel.org/
>
> [PATCH] iio:magn:hmc5843: Fix passing true where iio_shared_by enum required.
> https://lore.kernel.org/linux-iio/20200913112546.715624-1-jic23@kernel.org/
>
> [PATCH] iio:accel:bma180: Fix use of true when should be iio_shared_by enum
> https://lore.kernel.org/linux-iio/20200913121227.764626-1-jic23@kernel.org/
>
> For those last 2 I forgot I'd previously sent effectively the same fixes out
> earlier in the year but didn't get any reviews then either :(
>
> Note I've randomly picked a few people who have done reviews or posted a lot
> of patches recently for the cc list.  I'm more than happy if anyone else
> wants to join in with the fun :)  Reviews are always appreciated for any
> code submitted to IIO from anyone.  If you are unsure about something in
> a review, it is fine to say so.  Hence even relatively new people can
> offer great value.  We all started somewhere!
>
> Thanks,
>
> Jonathan



-- 
With Best Regards,
Andy Shevchenko

Re: IIO: Review request.

[Jonathan Cameron]

On Fri, 18 Sep 2020 17:05:29 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Fri, Sep 18, 2020 at 3:34 PM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > Hi All,
> >
> > Classic being the maintainer problem, is that there is no one specific to pester
> > when you can't get reviews on your own patches.  Hence if anyone has some
> > time I'd appreciate sanity checks on:
> >
> > [PATCH 2/3] iio: Add __printf() attributes to various allocation functions
> > https://lore.kernel.org/linux-iio/20200913132115.800131-3-jic23@kernel.org/
> >  
> 
> Examples show that rather
> static __printf() for the first occurrence. Otherwise the entire list
> of these patches LGTM. You may put my Rb tag.

Thanks to everyone who jumped on these.

I'll fix up that and pick them up shortly.

Jonathan

> 
> > [PATCH 3/3] iio:core: Tidy up kernel-doc.
> > https://lore.kernel.org/linux-iio/20200913132115.800131-4-jic23@kernel.org/
> >
> > [PATCH] iio:magn:hmc5843: Fix passing true where iio_shared_by enum required.
> > https://lore.kernel.org/linux-iio/20200913112546.715624-1-jic23@kernel.org/
> >
> > [PATCH] iio:accel:bma180: Fix use of true when should be iio_shared_by enum
> > https://lore.kernel.org/linux-iio/20200913121227.764626-1-jic23@kernel.org/
> >
> > For those last 2 I forgot I'd previously sent effectively the same fixes out
> > earlier in the year but didn't get any reviews then either :(
> >
> > Note I've randomly picked a few people who have done reviews or posted a lot
> > of patches recently for the cc list.  I'm more than happy if anyone else
> > wants to join in with the fun :)  Reviews are always appreciated for any
> > code submitted to IIO from anyone.  If you are unsure about something in
> > a review, it is fine to say so.  Hence even relatively new people can
> > offer great value.  We all started somewhere!
> >
> > Thanks,
> >
> > Jonathan  
> 
> 
>