Linux-IIO Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] staging: iio: adis16240: add blank line before struct definition
@ 2020-10-11 10:48 Deepak R Varma
  2020-10-11 11:06 ` [Outreachy kernel] " Julia Lawall
  0 siblings, 1 reply; 3+ messages in thread
From: Deepak R Varma @ 2020-10-11 10:48 UTC (permalink / raw)
  To: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
	Peter Meerwald-Stadler, Greg Kroah-Hartman
  Cc: linux-iio, outreachy-kernel

Add a blank line before starting structure definition as per coding
style guidelines. Issue reported by checkpatch script.

Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
---
 drivers/staging/iio/accel/adis16240.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c
index 5064adce5f58..8d3afc6dc755 100644
--- a/drivers/staging/iio/accel/adis16240.c
+++ b/drivers/staging/iio/accel/adis16240.c
@@ -426,6 +426,7 @@ static int adis16240_probe(struct spi_device *spi)
 
 	return devm_iio_device_register(&spi->dev, indio_dev);
 }
+
 static const struct of_device_id adis16240_of_match[] = {
 	{ .compatible = "adi,adis16240" },
 	{ },
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Outreachy kernel] [PATCH] staging: iio: adis16240: add blank line before struct definition
  2020-10-11 10:48 [PATCH] staging: iio: adis16240: add blank line before struct definition Deepak R Varma
@ 2020-10-11 11:06 ` Julia Lawall
  2020-10-11 17:11   ` Jonathan Cameron
  0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2020-10-11 11:06 UTC (permalink / raw)
  To: Deepak R Varma
  Cc: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
	Peter Meerwald-Stadler, Greg Kroah-Hartman, linux-iio,
	outreachy-kernel



On Sun, 11 Oct 2020, Deepak R Varma wrote:

> Add a blank line before starting structure definition as per coding
> style guidelines. Issue reported by checkpatch script.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>

Acked-by: Julia Lawall <julia.lawall@inria.fr>

> ---
>  drivers/staging/iio/accel/adis16240.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c
> index 5064adce5f58..8d3afc6dc755 100644
> --- a/drivers/staging/iio/accel/adis16240.c
> +++ b/drivers/staging/iio/accel/adis16240.c
> @@ -426,6 +426,7 @@ static int adis16240_probe(struct spi_device *spi)
>
>  	return devm_iio_device_register(&spi->dev, indio_dev);
>  }
> +
>  static const struct of_device_id adis16240_of_match[] = {
>  	{ .compatible = "adi,adis16240" },
>  	{ },
> --
> 2.25.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20201011104800.GA29412%40ubuntu204.
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Outreachy kernel] [PATCH] staging: iio: adis16240: add blank line before struct definition
  2020-10-11 11:06 ` [Outreachy kernel] " Julia Lawall
@ 2020-10-11 17:11   ` Jonathan Cameron
  0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2020-10-11 17:11 UTC (permalink / raw)
  To: Julia Lawall
  Cc: Deepak R Varma, Lars-Peter Clausen, Michael Hennerich,
	Peter Meerwald-Stadler, Greg Kroah-Hartman, linux-iio,
	outreachy-kernel

On Sun, 11 Oct 2020 13:06:06 +0200 (CEST)
Julia Lawall <julia.lawall@inria.fr> wrote:

> On Sun, 11 Oct 2020, Deepak R Varma wrote:
> 
> > Add a blank line before starting structure definition as per coding
> > style guidelines. Issue reported by checkpatch script.
> >
> > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>  
> 
> Acked-by: Julia Lawall <julia.lawall@inria.fr>

Hi Deepak / Julia.

Applied to the togreg branch of iio.git.  Initially I'll be pushing that
out as testing, so that various systems that run build tests can check
we haven't missed anything.   Clearly they won't be finding anything in
this particular patch, but there are other things in that branch that
may be more problematic.

Given timing wrt to the merge window, these won't go upstream until
next cycle.  I will probably send Greg KH a pull request in a few
weeks time (after rc1) including this patch.

Thanks,

Jonathan


> 
> > ---
> >  drivers/staging/iio/accel/adis16240.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c
> > index 5064adce5f58..8d3afc6dc755 100644
> > --- a/drivers/staging/iio/accel/adis16240.c
> > +++ b/drivers/staging/iio/accel/adis16240.c
> > @@ -426,6 +426,7 @@ static int adis16240_probe(struct spi_device *spi)
> >
> >  	return devm_iio_device_register(&spi->dev, indio_dev);
> >  }
> > +
> >  static const struct of_device_id adis16240_of_match[] = {
> >  	{ .compatible = "adi,adis16240" },
> >  	{ },
> > --
> > 2.25.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20201011104800.GA29412%40ubuntu204.
> >  


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-11 10:48 [PATCH] staging: iio: adis16240: add blank line before struct definition Deepak R Varma
2020-10-11 11:06 ` [Outreachy kernel] " Julia Lawall
2020-10-11 17:11   ` Jonathan Cameron

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org
	public-inbox-index linux-iio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git