* [PATCH v4] iio: light: vcnl4035 add i2c_device_id
@ 2020-10-18 19:53 Vaishnav M A
2020-11-01 15:26 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Vaishnav M A @ 2020-10-18 19:53 UTC (permalink / raw)
To: andy.shevchenko, jic23, wsa, knaack.h, lars, alexandru.ardelean,
matt.ranostay, linux-iio, linux-kernel
Add i2c_device_id table for the vcnl4035 driver,
enabling device instantiation using i2c_new_client_device()
or from userspace in cases where device-tree based description
is not possible now, like device(s) on a gbphy i2c adapter
created by greybus.
Signed-off-by: Vaishnav M A <vaishnav@beagleboard.org>
---
v4:
-update commit message, add punctuation.
v3:
-modify commit message for readability
as suggested by Jonathan Cameron
v2:
-fix commit message
drivers/iio/light/vcnl4035.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
index 765c44adac57..73a28e30dddc 100644
--- a/drivers/iio/light/vcnl4035.c
+++ b/drivers/iio/light/vcnl4035.c
@@ -652,6 +652,12 @@ static const struct dev_pm_ops vcnl4035_pm_ops = {
vcnl4035_runtime_resume, NULL)
};
+static const struct i2c_device_id vcnl4035_id[] = {
+ { "vcnl4035", 0},
+ { }
+};
+MODULE_DEVICE_TABLE(i2c, vcnl4035_id);
+
static const struct of_device_id vcnl4035_of_match[] = {
{ .compatible = "vishay,vcnl4035", },
{ }
@@ -666,6 +672,7 @@ static struct i2c_driver vcnl4035_driver = {
},
.probe = vcnl4035_probe,
.remove = vcnl4035_remove,
+ .id_table = vcnl4035_id,
};
module_i2c_driver(vcnl4035_driver);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4] iio: light: vcnl4035 add i2c_device_id
2020-10-18 19:53 [PATCH v4] iio: light: vcnl4035 add i2c_device_id Vaishnav M A
@ 2020-11-01 15:26 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2020-11-01 15:26 UTC (permalink / raw)
To: Vaishnav M A
Cc: andy.shevchenko, wsa, knaack.h, lars, alexandru.ardelean,
matt.ranostay, linux-iio, linux-kernel
On Mon, 19 Oct 2020 01:23:57 +0530
Vaishnav M A <vaishnav@beagleboard.org> wrote:
> Add i2c_device_id table for the vcnl4035 driver,
> enabling device instantiation using i2c_new_client_device()
> or from userspace in cases where device-tree based description
> is not possible now, like device(s) on a gbphy i2c adapter
> created by greybus.
>
> Signed-off-by: Vaishnav M A <vaishnav@beagleboard.org>
Applied,
Thanks,
Jonathan
> ---
> v4:
> -update commit message, add punctuation.
> v3:
> -modify commit message for readability
> as suggested by Jonathan Cameron
> v2:
> -fix commit message
> drivers/iio/light/vcnl4035.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
> index 765c44adac57..73a28e30dddc 100644
> --- a/drivers/iio/light/vcnl4035.c
> +++ b/drivers/iio/light/vcnl4035.c
> @@ -652,6 +652,12 @@ static const struct dev_pm_ops vcnl4035_pm_ops = {
> vcnl4035_runtime_resume, NULL)
> };
>
> +static const struct i2c_device_id vcnl4035_id[] = {
> + { "vcnl4035", 0},
> + { }
> +};
> +MODULE_DEVICE_TABLE(i2c, vcnl4035_id);
> +
> static const struct of_device_id vcnl4035_of_match[] = {
> { .compatible = "vishay,vcnl4035", },
> { }
> @@ -666,6 +672,7 @@ static struct i2c_driver vcnl4035_driver = {
> },
> .probe = vcnl4035_probe,
> .remove = vcnl4035_remove,
> + .id_table = vcnl4035_id,
> };
>
> module_i2c_driver(vcnl4035_driver);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-01 15:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-18 19:53 [PATCH v4] iio: light: vcnl4035 add i2c_device_id Vaishnav M A
2020-11-01 15:26 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).