linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: linux-iio@vger.kernel.org
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH] iio:accel:stk8312: Add lowercase i2c device id
Date: Sat, 24 Apr 2021 18:22:20 +0100	[thread overview]
Message-ID: <20210424182208.768e7467@jic23-huawei> (raw)
In-Reply-To: <20210401144226.225928-1-jic23@kernel.org>

On Thu,  1 Apr 2021 15:42:26 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> These are never upper case.  Chances are that all users of this driver
> were using the ACPI binding but just in case keep the uppercase version
> but mark it deprecated.
> 
> Whilst here tidy up some spacing.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
I'm not going to pester anyone about reviewing this given how trivial it is.

Hence applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to poke at it and prove it's not as trivial as I'm assuming ;(

Jonathan

> ---
>  drivers/iio/accel/stk8312.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/accel/stk8312.c b/drivers/iio/accel/stk8312.c
> index 157d8faefb9e..60aecfa9fd92 100644
> --- a/drivers/iio/accel/stk8312.c
> +++ b/drivers/iio/accel/stk8312.c
> @@ -635,13 +635,15 @@ static SIMPLE_DEV_PM_OPS(stk8312_pm_ops, stk8312_suspend, stk8312_resume);
>  #endif
>  
>  static const struct i2c_device_id stk8312_i2c_id[] = {
> -	{"STK8312", 0},
> +	/* Deprecated in favour of lowercase form */
> +	{ "STK8312", 0 },
> +	{ "stk8312", 0 },
>  	{}
>  };
>  MODULE_DEVICE_TABLE(i2c, stk8312_i2c_id);
>  
>  static const struct acpi_device_id stk8312_acpi_id[] = {
> -	{"STK8312", 0},
> +	{ "STK8312", 0 },
>  	{}
>  };
>  


      reply	other threads:[~2021-04-24 17:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01 14:42 [PATCH] iio:accel:stk8312: Add lowercase i2c device id Jonathan Cameron
2021-04-24 17:22 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210424182208.768e7467@jic23-huawei \
    --to=jic23@jic23.retrosnub.co.uk \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).