linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] iio:accel:stk8312: Add lowercase i2c device id
@ 2021-04-01 14:42 Jonathan Cameron
  2021-04-24 17:22 ` Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Cameron @ 2021-04-01 14:42 UTC (permalink / raw)
  To: linux-iio; +Cc: Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

These are never upper case.  Chances are that all users of this driver
were using the ACPI binding but just in case keep the uppercase version
but mark it deprecated.

Whilst here tidy up some spacing.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/accel/stk8312.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/accel/stk8312.c b/drivers/iio/accel/stk8312.c
index 157d8faefb9e..60aecfa9fd92 100644
--- a/drivers/iio/accel/stk8312.c
+++ b/drivers/iio/accel/stk8312.c
@@ -635,13 +635,15 @@ static SIMPLE_DEV_PM_OPS(stk8312_pm_ops, stk8312_suspend, stk8312_resume);
 #endif
 
 static const struct i2c_device_id stk8312_i2c_id[] = {
-	{"STK8312", 0},
+	/* Deprecated in favour of lowercase form */
+	{ "STK8312", 0 },
+	{ "stk8312", 0 },
 	{}
 };
 MODULE_DEVICE_TABLE(i2c, stk8312_i2c_id);
 
 static const struct acpi_device_id stk8312_acpi_id[] = {
-	{"STK8312", 0},
+	{ "STK8312", 0 },
 	{}
 };
 
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] iio:accel:stk8312: Add lowercase i2c device id
  2021-04-01 14:42 [PATCH] iio:accel:stk8312: Add lowercase i2c device id Jonathan Cameron
@ 2021-04-24 17:22 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2021-04-24 17:22 UTC (permalink / raw)
  To: linux-iio; +Cc: Jonathan Cameron

On Thu,  1 Apr 2021 15:42:26 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> These are never upper case.  Chances are that all users of this driver
> were using the ACPI binding but just in case keep the uppercase version
> but mark it deprecated.
> 
> Whilst here tidy up some spacing.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
I'm not going to pester anyone about reviewing this given how trivial it is.

Hence applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to poke at it and prove it's not as trivial as I'm assuming ;(

Jonathan

> ---
>  drivers/iio/accel/stk8312.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/accel/stk8312.c b/drivers/iio/accel/stk8312.c
> index 157d8faefb9e..60aecfa9fd92 100644
> --- a/drivers/iio/accel/stk8312.c
> +++ b/drivers/iio/accel/stk8312.c
> @@ -635,13 +635,15 @@ static SIMPLE_DEV_PM_OPS(stk8312_pm_ops, stk8312_suspend, stk8312_resume);
>  #endif
>  
>  static const struct i2c_device_id stk8312_i2c_id[] = {
> -	{"STK8312", 0},
> +	/* Deprecated in favour of lowercase form */
> +	{ "STK8312", 0 },
> +	{ "stk8312", 0 },
>  	{}
>  };
>  MODULE_DEVICE_TABLE(i2c, stk8312_i2c_id);
>  
>  static const struct acpi_device_id stk8312_acpi_id[] = {
> -	{"STK8312", 0},
> +	{ "STK8312", 0 },
>  	{}
>  };
>  


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-24 17:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-01 14:42 [PATCH] iio:accel:stk8312: Add lowercase i2c device id Jonathan Cameron
2021-04-24 17:22 ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).