From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] iio: bme680_i2c: Make bme680_acpi_match depend on CONFIG_ACPI
Date: Wed, 5 May 2021 09:32:35 +0100 [thread overview]
Message-ID: <20210505093235.00007c38@Huawei.com> (raw)
In-Reply-To: <8f8b6f33-4308-bfda-2238-9a54e19c3f9f@roeck-us.net>
On Tue, 4 May 2021 11:00:52 -0700
Guenter Roeck <linux@roeck-us.net> wrote:
> On 5/4/21 10:44 AM, Andy Shevchenko wrote:
> > On Tue, May 4, 2021 at 8:40 PM Guenter Roeck <linux@roeck-us.net> wrote:
> >>
> >> With CONFIG_ACPI=n and -Werror, 0-day reports:
> >>
> >> drivers/iio/chemical/bme680_i2c.c:46:36: error:
> >> 'bme680_acpi_match' defined but not used
> >
> >> Given the other patch, question of course is if this ACPI ID
> >> is real. A Google search suggests that this might not be the case.
> >> Should we remove it as well ? STK8312 has the same problem.
> >
> > For this one definitely removal. Looking into the code it suggests a
> > cargo cult taken that time by a few contributors to invent fake ACPI
> > IDs while submitting new drivers.
> > Feel free to add my tag or if you wish me I'll add it explicitly.
> >
>
> I'll resend and let you add the tag, and send a similar patch
> for STK8312. I'll wait until tomorrow, though - I sent a number of
> patches today already, and I want to avoid yet another "account
> suspended" notice from gmail.
If you find some valid ACPI entries that are hitting this problem,
I'd prefer we just got rid of the ACPI_PTR() usecases rather than
added IFDEF magic.
The space wasted by having these is trivial and I'd rather not
introduce ifdef around any of these tables.
Dropping the ones we are fairly sure are spurious is even better!
Thanks,
Jonathan
>
> Thanks,
> Guenter
next prev parent reply other threads:[~2021-05-05 8:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 17:40 [PATCH] iio: bme680_i2c: Make bme680_acpi_match depend on CONFIG_ACPI Guenter Roeck
2021-05-04 17:44 ` Andy Shevchenko
2021-05-04 17:46 ` Andy Shevchenko
2021-05-04 18:00 ` Guenter Roeck
2021-05-05 8:32 ` Jonathan Cameron [this message]
2021-05-05 8:34 ` Jonathan Cameron
2021-05-05 13:00 ` Guenter Roeck
2021-05-05 13:22 ` Andy Shevchenko
2021-05-05 13:39 ` Hans de Goede
2021-05-05 13:53 ` Andy Shevchenko
2021-05-05 14:04 ` Hans de Goede
2021-05-05 14:18 ` Andy Shevchenko
2021-05-05 15:19 ` Hans de Goede
2021-05-05 16:26 ` Andy Shevchenko
2021-05-05 16:30 ` Hans de Goede
2021-05-07 11:53 ` Pavel Machek
2021-05-07 12:39 ` Andy Shevchenko
2021-05-05 9:04 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210505093235.00007c38@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).