From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Pavel Machek <pavel@denx.de>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Hans de Goede <hdegoede@redhat.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Paul Menzel <paulepanter@users.sourceforge.net>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] iio: bme680_i2c: Make bme680_acpi_match depend on CONFIG_ACPI
Date: Fri, 7 May 2021 15:39:57 +0300 [thread overview]
Message-ID: <CAHp75VcxQYp0V9oM_UYMfwcR1GMo+MTYgurj2qichGgpDzm4SA@mail.gmail.com> (raw)
In-Reply-To: <20210507115302.GA20751@amd>
On Fri, May 7, 2021 at 2:53 PM Pavel Machek <pavel@denx.de> wrote:
> On Wed 2021-05-05 16:22:07, Andy Shevchenko wrote:
> > On Wed, May 5, 2021 at 11:36 AM Jonathan Cameron
> > <Jonathan.Cameron@huawei.com> wrote:
> > > On Wed, 5 May 2021 09:32:35 +0100
> > > Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:
> > > > On Tue, 4 May 2021 11:00:52 -0700
> > > > Guenter Roeck <linux@roeck-us.net> wrote:
> >
> > +Cc: Paul (I hope you are related to coreboot somehow and can
> > communicate this further), Pavel and Jacek (LED subsystem suffered
> > with this as well), Hans, Rafael and linux-acpi@
>
> Thanks for Cc. I prefer @ucw.cz address for the LED work.
Noted!
> > > > Dropping the ones we are fairly sure are spurious is even better!
> > >
> > > If I get bored I'll just do a scrub of all the instances of this that
> > > you haven't already cleaned up. It's worth noting that we do
> > > know some highly suspicious looking entries are out there in the wild.
> >
> > I have counted ~60 users of acpi_device_id in IIO. Brief looking at
> > the IDs themselves rings an alarm about half of them.
>
> As far as I can tell, this means asking "is this real ID or did you
> just invent it" at patch submission. Okay...
I would put it in a way that "Please, provide an ASL excerpt / ACPI
tables dump" or something alike. Because it may also show some
additional information that would make sense to consider when adding
an ID to the driver.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-05-07 12:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 17:40 [PATCH] iio: bme680_i2c: Make bme680_acpi_match depend on CONFIG_ACPI Guenter Roeck
2021-05-04 17:44 ` Andy Shevchenko
2021-05-04 17:46 ` Andy Shevchenko
2021-05-04 18:00 ` Guenter Roeck
2021-05-05 8:32 ` Jonathan Cameron
2021-05-05 8:34 ` Jonathan Cameron
2021-05-05 13:00 ` Guenter Roeck
2021-05-05 13:22 ` Andy Shevchenko
2021-05-05 13:39 ` Hans de Goede
2021-05-05 13:53 ` Andy Shevchenko
2021-05-05 14:04 ` Hans de Goede
2021-05-05 14:18 ` Andy Shevchenko
2021-05-05 15:19 ` Hans de Goede
2021-05-05 16:26 ` Andy Shevchenko
2021-05-05 16:30 ` Hans de Goede
2021-05-07 11:53 ` Pavel Machek
2021-05-07 12:39 ` Andy Shevchenko [this message]
2021-05-05 9:04 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcxQYp0V9oM_UYMfwcR1GMo+MTYgurj2qichGgpDzm4SA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=hdegoede@redhat.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
--cc=paulepanter@users.sourceforge.net \
--cc=pavel@denx.de \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).