From: Sean Nyekjaer <sean@geanix.com>
To: lorenzo.bianconi83@gmail.com, jic23@kernel.org
Cc: Sean Nyekjaer <sean@geanix.com>, linux-iio@vger.kernel.org
Subject: [PATCH] iio: imu: st_lsm6dsx: do not roundup set samplerate
Date: Fri, 7 May 2021 12:32:20 +0200 [thread overview]
Message-ID: <20210507103220.2194009-1-sean@geanix.com> (raw)
The correct way to set the sampling rate to 12.5 Hz before
commit f8710f0357bc ("iio: imu: st_lsm6dsx: express odr in mHZ")
was to write 13 Hz to sampling_frequency.
Before this patch writing 13 to samplerate results in sample rate set
to 26 Hz.
Now we return EINVAL if the sampling rate is not in table.
Signed-off-by: Sean Nyekjaer <sean@geanix.com>
---
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
index a3ab16615729..a14a1df8537b 100644
--- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
+++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
@@ -1427,7 +1427,7 @@ int st_lsm6dsx_check_odr(struct st_lsm6dsx_sensor *sensor, u32 odr, u8 *val)
* ext devices can run at different odr respect to
* accel sensor
*/
- if (odr_table->odr_avl[i].milli_hz >= odr)
+ if (odr_table->odr_avl[i].milli_hz == odr)
break;
}
--
2.31.0
next reply other threads:[~2021-05-07 10:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 10:32 Sean Nyekjaer [this message]
2021-05-07 11:02 ` [PATCH] iio: imu: st_lsm6dsx: do not roundup set samplerate Lorenzo Bianconi
2021-05-10 5:25 ` Sean Nyekjaer
2021-05-10 6:28 ` Lorenzo Bianconi
2021-05-10 6:41 ` Sean Nyekjaer
2021-05-10 12:07 ` Lorenzo Bianconi
2021-05-10 12:14 ` Sean Nyekjaer
2021-05-10 14:47 ` Lorenzo Bianconi
2021-05-10 16:52 ` Sean Nyekjaer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210507103220.2194009-1-sean@geanix.com \
--to=sean@geanix.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).