From: Sean Nyekjaer <sean@geanix.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: lorenzo.bianconi83@gmail.com, jic23@kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: imu: st_lsm6dsx: do not roundup set samplerate
Date: Mon, 10 May 2021 07:25:53 +0200 [thread overview]
Message-ID: <d0b62523-dcc9-ff14-aeaf-db24915f7aeb@geanix.com> (raw)
In-Reply-To: <YJUeKhjooi8lAN1Q@lore-desk>
On 07/05/2021 13.02, Lorenzo Bianconi wrote:
>> The correct way to set the sampling rate to 12.5 Hz before
>> commit f8710f0357bc ("iio: imu: st_lsm6dsx: express odr in mHZ")
>> was to write 13 Hz to sampling_frequency.
>> Before this patch writing 13 to samplerate results in sample rate set
>> to 26 Hz.
>> Now we return EINVAL if the sampling rate is not in table.
>>
>> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
>
> I think this patch is breaking i2c-master support available in st_lsm6dsx, have you tested it?
>
I have not tested with i2c-master.
But it's not nice to round up sample rate from user space without any notice.
/Sean
next prev parent reply other threads:[~2021-05-10 5:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 10:32 [PATCH] iio: imu: st_lsm6dsx: do not roundup set samplerate Sean Nyekjaer
2021-05-07 11:02 ` Lorenzo Bianconi
2021-05-10 5:25 ` Sean Nyekjaer [this message]
2021-05-10 6:28 ` Lorenzo Bianconi
2021-05-10 6:41 ` Sean Nyekjaer
2021-05-10 12:07 ` Lorenzo Bianconi
2021-05-10 12:14 ` Sean Nyekjaer
2021-05-10 14:47 ` Lorenzo Bianconi
2021-05-10 16:52 ` Sean Nyekjaer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0b62523-dcc9-ff14-aeaf-db24915f7aeb@geanix.com \
--to=sean@geanix.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=lorenzo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).