From: Jonathan Cameron <jic23@kernel.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
~postmarketos/upstreaming@lists.sr.ht,
Nikita Travkin <nikita@trvn.ru>
Subject: Re: [PATCH 1/4] dt-bindings: iio: accel: bma255: Add interrupt-names
Date: Sat, 24 Jul 2021 17:00:07 +0100 [thread overview]
Message-ID: <20210724170007.40c93072@jic23-huawei> (raw)
In-Reply-To: <20210719112156.27087-2-stephan@gerhold.net>
On Mon, 19 Jul 2021 13:21:53 +0200
Stephan Gerhold <stephan@gerhold.net> wrote:
> The binding already allows specifying both interrupt pins, but there
> is currently no way to describe a board where (for whatever reason)
> only INT2 is connected. Make it possible to use "interrupt-names"
> to make it explicit which interrupt pin is meant in the interrupts.
>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> .../devicetree/bindings/iio/accel/bosch,bma255.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
> index 5b35856b1942..897a1d808ef5 100644
> --- a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
> @@ -49,6 +49,14 @@ properties:
> the second (optional) interrupt listed must be the one connected to the
> INT2 pin (if available). The type should be IRQ_TYPE_EDGE_RISING.
Looks like this comment needs updating to say the ordering is only true if
interrupt-names is not present.
Jonathan
>
> + interrupt-names:
> + minItems: 1
> + maxItems: 2
> + items:
> + enum:
> + - INT1
> + - INT2
> +
> mount-matrix:
> description: an optional 3x3 mounting rotation matrix.
>
> @@ -73,6 +81,7 @@ examples:
> vddio-supply = <&vddio>;
> vdd-supply = <&vdd>;
> interrupts = <57 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "INT1";
> };
> };
> - |
next prev parent reply other threads:[~2021-07-24 15:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 11:21 [PATCH 0/4] iio: accel: bmc150: Add support for INT2 and BMC156 Stephan Gerhold
2021-07-19 11:21 ` [PATCH 1/4] dt-bindings: iio: accel: bma255: Add interrupt-names Stephan Gerhold
2021-07-19 13:57 ` Linus Walleij
2021-07-24 16:00 ` Jonathan Cameron [this message]
2021-07-19 11:21 ` [PATCH 2/4] dt-bindings: iio: accel: bma255: Add bosch,bmc156_accel Stephan Gerhold
2021-07-19 13:58 ` Linus Walleij
2021-07-24 16:03 ` Jonathan Cameron
2021-07-29 19:10 ` Rob Herring
2021-07-29 19:10 ` Rob Herring
2021-07-19 11:21 ` [PATCH 3/4] iio: accel: bmc150: Make it possible to configure INT2 instead of INT1 Stephan Gerhold
2021-07-19 14:07 ` Linus Walleij
2021-07-19 15:01 ` Andy Shevchenko
2021-07-19 15:10 ` Stephan Gerhold
2021-07-19 16:19 ` Andy Shevchenko
2021-07-19 17:26 ` Stephan Gerhold
2021-07-19 18:05 ` Andy Shevchenko
2021-07-19 18:36 ` Stephan Gerhold
2021-07-20 15:04 ` Andy Shevchenko
2021-07-24 16:19 ` Jonathan Cameron
2021-07-24 18:06 ` Jonathan Cameron
2021-07-19 11:21 ` [PATCH 4/4] iio: accel: bmc150: Add support for BMC156 Stephan Gerhold
2021-07-19 14:08 ` Linus Walleij
2021-07-24 16:12 ` Jonathan Cameron
2021-07-27 18:32 ` Stephan Gerhold
2021-07-31 18:04 ` Jonathan Cameron
2021-07-19 12:34 ` [PATCH 0/4] iio: accel: bmc150: Add support for INT2 and BMC156 Andy Shevchenko
2021-07-19 12:42 ` Stephan Gerhold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210724170007.40c93072@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=nikita@trvn.ru \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).