From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Alexandru Ardelean <ardeleanalex@gmail.com>,
linux-iio <linux-iio@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 09/10] iio: core: Simplify the registration of kfifo buffers
Date: Wed, 2 Feb 2022 09:09:36 +0100 [thread overview]
Message-ID: <20220202090936.3621d0eb@xps13> (raw)
In-Reply-To: <20220115171246.59915cd2@jic23-huawei>
Hi Jonathan,
jic23@kernel.org wrote on Sat, 15 Jan 2022 17:12:46 +0000:
> On Thu, 16 Dec 2021 09:52:38 +0200
> Alexandru Ardelean <ardeleanalex@gmail.com> wrote:
>
> > On Wed, Dec 15, 2021 at 10:04 PM Miquel Raynal
> > <miquel.raynal@bootlin.com> wrote:
> > >
> > > Among all the users of the kfifo buffers, no one uses the
> > > INDIO_BUFFER_HARDWARE mode. So let's take this as a general rule and
> > > simplify a little bit the internals - overall the documentation - by
> > > eliminating unused specific cases. Use the INDIO_BUFFER_SOFTWARE mode by
> > > default with kfifo buffers, which will basically mimic what all the "non
> > > direct" modes do.
> > >
> >
> > I think this patch here (and 10/10) can be part of a separate series.
> > This discussion is important enough to have it's own series.
> > It's a bit of an API discussion.
> >
> One question inline.
>
> > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > > ---
> > > drivers/iio/accel/fxls8962af-core.c | 1 -
> > > drivers/iio/accel/sca3000.c | 1 -
> > > drivers/iio/accel/ssp_accel_sensor.c | 1 -
> > > drivers/iio/adc/ina2xx-adc.c | 1 -
> > > drivers/iio/adc/ti_am335x_adc.c | 4 +---
> > > drivers/iio/buffer/kfifo_buf.c | 12 ++----------
> > > .../common/cros_ec_sensors/cros_ec_sensors_core.c | 3 +--
> > > drivers/iio/common/scmi_sensors/scmi_iio.c | 1 -
> > > drivers/iio/gyro/ssp_gyro_sensor.c | 1 -
> > > drivers/iio/health/max30100.c | 1 -
> > > drivers/iio/health/max30102.c | 1 -
> > > drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c | 1 -
> > > drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c | 1 -
> > > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c | 1 -
> > > drivers/iio/light/apds9960.c | 1 -
> > > drivers/staging/iio/impedance-analyzer/ad5933.c | 1 -
> > > include/linux/iio/kfifo_buf.h | 5 ++---
> > > 17 files changed, 6 insertions(+), 31 deletions(-)
[...]
> > > --- a/drivers/iio/adc/ti_am335x_adc.c
> > > +++ b/drivers/iio/adc/ti_am335x_adc.c
> > > @@ -376,9 +376,7 @@ static int tiadc_iio_buffered_hardware_setup(struct device *dev,
> > > {
> > > int ret;
> > >
> > > - ret = devm_iio_kfifo_buffer_setup(dev, indio_dev,
> > > - INDIO_BUFFER_SOFTWARE,
> > > - setup_ops);
> > > + ret = devm_iio_kfifo_buffer_setup(dev, indio_dev, setup_ops);
> > > if (ret)
> > > return ret;
> > >
> > > diff --git a/drivers/iio/buffer/kfifo_buf.c b/drivers/iio/buffer/kfifo_buf.c
> > > index 416d35a61ae2..f17473e06ee8 100644
> > > --- a/drivers/iio/buffer/kfifo_buf.c
> > > +++ b/drivers/iio/buffer/kfifo_buf.c
> > > @@ -197,7 +197,7 @@ static const struct iio_buffer_access_funcs kfifo_access_funcs = {
> > > .set_length = &iio_set_length_kfifo,
> > > .release = &iio_kfifo_buffer_release,
> > >
> > > - .modes = INDIO_BUFFER_SOFTWARE | INDIO_BUFFER_TRIGGERED,
> > > + .modes = INDIO_BUFFER_SOFTWARE,
>
> Why is this safe to do? Don't we need triggered buffers to match mode
> when used with a kfifo?
>
> If I'm remembering / reading how the mode matching works, this breaks the
> industrialio-triggered-buffer.c case where it sets the mode to
> INDIO_BUFFER_TRIGGERED (mostly I think to make sure we get a warning in
> iio_verify_update() if no trigger is supplied - I can't remember what other
> difference it makes (or if it does).
Mmmh that's right, I overlooked that part. Indeed we still need to
support the INDIO_BUFFER_TRIGGERED mode in the kfifo_access_funcs
modes.
Do you think the rest of the patch is still legit? I believe it stills
simplifies the logic for the user but if you disagree I'll drop it off
entirely.
Thanks,
Miquèl
next prev parent reply other threads:[~2022-02-02 8:09 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 15:13 [PATCH 00/10] Light core IIO enhancements Miquel Raynal
2021-12-15 15:13 ` [PATCH 01/10] iio: core: Fix the kernel doc regarding the currentmode iio_dev entry Miquel Raynal
2021-12-16 6:23 ` Alexandru Ardelean
2022-01-15 15:47 ` Jonathan Cameron
2021-12-15 15:13 ` [PATCH 02/10] iio: core: Enhance the kernel doc of modes and currentmodes iio_dev entries Miquel Raynal
2021-12-16 6:24 ` Alexandru Ardelean
2021-12-16 8:15 ` Miquel Raynal
2022-01-15 15:51 ` Jonathan Cameron
2022-01-28 14:56 ` Miquel Raynal
2021-12-15 15:13 ` [PATCH 03/10] iio: magnetometer: rm3100: Stop abusing the ->currentmode Miquel Raynal
2021-12-16 6:40 ` Alexandru Ardelean
2021-12-16 8:18 ` Miquel Raynal
2022-01-15 15:58 ` Jonathan Cameron
2022-01-28 15:00 ` Miquel Raynal
2021-12-15 15:13 ` [PATCH 04/10] iio: adc: stm32-dfsdm: Avoid dereferencing ->currentmode Miquel Raynal
2021-12-16 6:47 ` Alexandru Ardelean
2021-12-16 8:22 ` Miquel Raynal
2022-01-15 16:06 ` Jonathan Cameron
2022-01-28 15:04 ` Miquel Raynal
2022-02-01 8:41 ` Fabrice Gasnier
2022-02-02 9:33 ` Miquel Raynal
2021-12-15 15:13 ` [PATCH 05/10] iio: st_sensors: Use iio_device_claim/release_direct_mode() when relevant Miquel Raynal
2021-12-16 7:16 ` Alexandru Ardelean
2021-12-16 8:32 ` Miquel Raynal
2022-01-15 16:38 ` Jonathan Cameron
2021-12-15 15:13 ` [PATCH 06/10] iio: core: Hide read accesses to iio_dev->currentmode Miquel Raynal
2021-12-16 7:38 ` Alexandru Ardelean
2021-12-16 7:41 ` Alexandru Ardelean
2021-12-16 8:37 ` Miquel Raynal
2022-01-15 16:51 ` Jonathan Cameron
2021-12-15 15:13 ` [PATCH 07/10] iio: core: Hide write " Miquel Raynal
2022-01-15 16:56 ` Jonathan Cameron
2022-02-02 8:16 ` Miquel Raynal
2021-12-15 15:13 ` [PATCH 08/10] iio: core: Move iio_dev->currentmode to the opaque structure Miquel Raynal
2021-12-16 7:48 ` Alexandru Ardelean
2021-12-16 8:38 ` Miquel Raynal
2022-01-15 17:00 ` Jonathan Cameron
2021-12-15 15:13 ` [PATCH 09/10] iio: core: Simplify the registration of kfifo buffers Miquel Raynal
2021-12-16 7:52 ` Alexandru Ardelean
2022-01-15 17:12 ` Jonathan Cameron
2022-02-02 8:09 ` Miquel Raynal [this message]
2022-02-05 18:50 ` Jonathan Cameron
2021-12-15 15:13 ` [PATCH 10/10] iio: core: Clarify the modes Miquel Raynal
2022-01-15 17:30 ` Jonathan Cameron
2022-02-02 13:46 ` Miquel Raynal
2022-02-05 18:56 ` Jonathan Cameron
2022-02-06 13:21 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220202090936.3621d0eb@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=ardeleanalex@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).