From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "jic23@kernel.org" <jic23@kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Cc: "manabian@gmail.com" <manabian@gmail.com>,
"Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH] iio: adc: lpc18xx: use devm_platform_ioremap_resource
Date: Mon, 4 Nov 2019 15:19:33 +0000 [thread overview]
Message-ID: <3579f153fbec2b9f60e3adaff094ae395bee57e4.camel@analog.com> (raw)
In-Reply-To: <20191013153234.1835827-1-jic23@kernel.org>
On Sun, 2019-10-13 at 16:32 +0100, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Avoid local boilerplate.
> Identified by coccinelle
>
> CHECK drivers/iio/adc/lpc18xx_adc.c
> drivers/iio/adc/lpc18xx_adc.c:137:1-10: WARNING: Use
> devm_platform_ioremap_resource for adc -> base
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Joachim Eastwood <manabian@gmail.com>
> ---
> drivers/iio/adc/lpc18xx_adc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/lpc18xx_adc.c
> b/drivers/iio/adc/lpc18xx_adc.c
> index e400a95f553d..4c6ac6644dc0 100644
> --- a/drivers/iio/adc/lpc18xx_adc.c
> +++ b/drivers/iio/adc/lpc18xx_adc.c
> @@ -119,7 +119,6 @@ static int lpc18xx_adc_probe(struct platform_device
> *pdev)
> {
> struct iio_dev *indio_dev;
> struct lpc18xx_adc *adc;
> - struct resource *res;
> unsigned int clkdiv;
> unsigned long rate;
> int ret;
> @@ -133,8 +132,7 @@ static int lpc18xx_adc_probe(struct platform_device
> *pdev)
> adc->dev = &pdev->dev;
> mutex_init(&adc->lock);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - adc->base = devm_ioremap_resource(&pdev->dev, res);
> + adc->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(adc->base))
> return PTR_ERR(adc->base);
>
next prev parent reply other threads:[~2019-11-04 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 15:32 [PATCH] iio: adc: lpc18xx: use devm_platform_ioremap_resource jic23
2019-11-04 15:19 ` Ardelean, Alexandru [this message]
2019-11-09 12:21 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3579f153fbec2b9f60e3adaff094ae395bee57e4.camel@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=manabian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).