From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "mh12gx2825@gmail.com" <mh12gx2825@gmail.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"outreachy-kernel@googlegroups.com"
<outreachy-kernel@googlegroups.com>,
"kieran.bingham@ideasonboard.com"
<kieran.bingham@ideasonboard.com>,
"daniel.baluta@gmail.com" <daniel.baluta@gmail.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
"jic23@kernel.org" <jic23@kernel.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>
Subject: Re: [PATCH v3 4/4] staging: iio: adc: ad7280a: Add comments to clarify stringified arguments
Date: Tue, 24 Mar 2020 08:07:28 +0000 [thread overview]
Message-ID: <9da7b4c4424cda9ab42353ab073d2a8313d978f8.camel@analog.com> (raw)
In-Reply-To: <469bf8db1c228913e72841367182fba2168fe795.1584904896.git.mh12gx2825@gmail.com>
On Mon, 2020-03-23 at 01:27 +0530, Deepak R Varma wrote:
> [External]
>
> Checkpatch would flash a check message around a stringified macro
> argument containing a '-' character. Add comment to indicate the
> argument is legitimate and doesn't need fixing.
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
>
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> Suggested-by: Lars-Peter Clausen <lars@metafoo.de>
>
> ---
>
> Changes since v2:
> - None. Patch added in v3
>
> Changes since v1:
> - None. Patch added in v3
>
> drivers/staging/iio/adc/ad7280a.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/staging/iio/adc/ad7280a.c
> b/drivers/staging/iio/adc/ad7280a.c
> index 19a5f244dcae..bef6bd1295ea 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -824,6 +824,10 @@ static irqreturn_t ad7280_event_handler(int irq, void
> *private)
> return IRQ_HANDLED;
> }
>
> +/* Note: No need to fix checkpatch warning that reads:
> + * CHECK: spaces preferred around that '-' (ctx:VxV)
> + * The function argument is stringified and doesn't need a fix
> + */
> static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
> in_voltage-voltage_thresh_low_value,
> 0644,
next prev parent reply other threads:[~2020-03-24 8:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 19:53 [PATCH v3 0/4] staging: iio: adc: General code reformatting / cleanup patchset Deepak R Varma
2020-03-22 19:54 ` [PATCH v3 1/4] staging: iio: adc: ad7192: Re-indent enum labels Deepak R Varma
2020-03-24 7:18 ` Ardelean, Alexandru
2020-03-26 8:19 ` Ardelean, Alexandru
2020-03-26 8:22 ` Ardelean, Alexandru
2020-03-22 19:55 ` [PATCH v3 2/4] staging: iio: adc: ad7192: Correct macro names from SYNC to SINC Deepak R Varma
2020-03-22 23:40 ` Andy Shevchenko
2020-03-23 17:50 ` DEEPAK VARMA
2020-03-26 8:20 ` Ardelean, Alexandru
2020-03-22 19:56 ` [PATCH v3 3/4] staging: iio: adc: ad7192: get_filter_freq code optimization Deepak R Varma
2020-03-22 23:44 ` Andy Shevchenko
2020-03-23 0:49 ` [Outreachy kernel] " Stefano Brivio
2020-03-23 9:28 ` Andy Shevchenko
2020-03-23 12:15 ` Stefano Brivio
2020-03-23 17:52 ` DEEPAK VARMA
2020-03-24 8:06 ` Ardelean, Alexandru
2020-03-25 17:38 ` DEEPAK VARMA
2020-03-25 19:37 ` Andy Shevchenko
2020-03-25 19:59 ` Stefano Brivio
2020-03-26 8:15 ` Ardelean, Alexandru
2020-03-22 19:57 ` [PATCH v3 4/4] staging: iio: adc: ad7280a: Add comments to clarify stringified arguments Deepak R Varma
2020-03-24 8:07 ` Ardelean, Alexandru [this message]
2020-03-28 13:28 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9da7b4c4424cda9ab42353ab073d2a8313d978f8.camel@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=daniel.baluta@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mh12gx2825@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).