linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: trix@redhat.com
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC] treewide: cleanup unreachable breaks
Date: Sat, 17 Oct 2020 18:24:28 +0200	[thread overview]
Message-ID: <CAFBinCAqvqp14ygOzQW=OPi7CY5z7qAcvcUHZs7Zf6JaHbNYXg@mail.gmail.com> (raw)
In-Reply-To: <20201017160928.12698-1-trix@redhat.com>

Hi Tom,

(I removed what I believe are irrelevant recipients from this reply)

On Sat, Oct 17, 2020 at 6:10 PM <trix@redhat.com> wrote:
[...]
> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
> index e03988698755..66dc452d643a 100644
> --- a/drivers/iio/adc/meson_saradc.c
> +++ b/drivers/iio/adc/meson_saradc.c
> @@ -591,17 +591,15 @@ static int meson_sar_adc_iio_info_read_raw(struct iio_dev *indio_dev,
>
>         switch (mask) {
>         case IIO_CHAN_INFO_RAW:
>                 return meson_sar_adc_get_sample(indio_dev, chan, NO_AVERAGING,
>                                                 ONE_SAMPLE, val);
> -               break;
>
>         case IIO_CHAN_INFO_AVERAGE_RAW:
>                 return meson_sar_adc_get_sample(indio_dev, chan,
>                                                 MEAN_AVERAGING, EIGHT_SAMPLES,
>                                                 val);
> -               break;
>
>         case IIO_CHAN_INFO_SCALE:
>                 if (chan->type == IIO_VOLTAGE) {
>                         ret = regulator_get_voltage(priv->vref);
>                         if (ret < 0) {
for drivers/iio/adc/meson_saradc.c:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>


Best regards,
Martin

  reply	other threads:[~2020-10-17 16:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-17 16:09 [RFC] treewide: cleanup unreachable breaks trix
2020-10-17 16:24 ` Martin Blumenstingl [this message]
2020-10-17 16:24 ` Joe Perches
2020-10-17 18:21   ` [Cocci] " Julia Lawall
2020-10-17 19:00     ` Joe Perches
2020-10-17 21:01 ` Dan Williams
2020-10-18  5:43 ` Greg KH
2020-10-18 14:04   ` Tom Rix
2020-10-19 19:42   ` Nick Desaulniers
2020-10-19 23:05     ` Jason Gunthorpe
2020-10-20 14:09       ` Tom Rix
2020-10-20  8:47     ` [Ocfs2-devel] " John Haxby
2020-10-20 13:55     ` Tom Rix
2020-10-20 18:42     ` Joe Perches
2020-10-18  9:29 ` Hans de Goede
2020-10-18 18:59 ` [Ocfs2-devel] " Matthew Wilcox
2020-10-18 19:06   ` Joe Perches
2020-10-18 19:13   ` James Bottomley
2020-10-18 19:16     ` Matthew Wilcox
2020-10-18 19:17       ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFBinCAqvqp14ygOzQW=OPi7CY5z7qAcvcUHZs7Zf6JaHbNYXg@mail.gmail.com' \
    --to=martin.blumenstingl@googlemail.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).