From: Sven Van Asbroeck <thesven73@gmail.com>
To: Jonathan Cameron <jonathan.cameron@huawei.com>
Cc: Robert Eshleman <bobbyeshleman@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/3] iio: light: Add driver for ap3216c
Date: Mon, 18 Feb 2019 12:13:59 -0500 [thread overview]
Message-ID: <CAGngYiXz=o6m41wsETbt7i9c6Ut=GsW2Kvf8cwhqSQnO6Jg4zA@mail.gmail.com> (raw)
In-Reply-To: <20190218152224.00007920@huawei.com>
Hello Jonathan,
First of all, thank you so much for taking the time for such a detailed
reply !
On Mon, Feb 18, 2019 at 10:22 AM Jonathan Cameron
<jonathan.cameron@huawei.com> wrote:
>
>
> So, what I'm reading above is worrying. The interrupt is cleared
> by the read of the data registers? I thought the datasheet allowed
> for an explicit clear?
>
I don't think there's any need to worry. The part allows us to choose between
clear-on-read, and explicit clear. Bobby's approach is fundamentally sound.
IMHO most of my suggestions were based on an incomplete understanding of
a) the interrupt in the device, and b) the event guarantees in iio.
I will respond to your larger reply properly soon.
prev parent reply other threads:[~2019-02-18 17:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-10 20:36 [PATCH 1/3] iio: light: Add driver for ap3216c Robert Eshleman
2019-02-10 20:39 ` [PATCH 3/3] dt-bindings: iio: light: Add ap3216c Robert Eshleman
2019-02-11 14:58 ` [PATCH 1/3] iio: light: Add driver for ap3216c Peter Meerwald-Stadler
2019-02-13 16:33 ` Robert Eshleman
2019-02-11 19:09 ` Sven Van Asbroeck
2019-02-11 21:27 ` Jonathan Cameron
2019-02-11 22:30 ` Sven Van Asbroeck
2019-02-12 20:47 ` Jonathan Cameron
2019-02-13 4:40 ` Sven Van Asbroeck
2019-02-13 4:56 ` Sven Van Asbroeck
2019-02-18 15:16 ` Jonathan Cameron
2019-02-18 19:35 ` Sven Van Asbroeck
2019-02-20 12:32 ` Jonathan Cameron
2019-02-20 15:09 ` Sven Van Asbroeck
2019-02-13 16:18 ` Robert Eshleman
2019-02-11 19:29 ` Sven Van Asbroeck
2019-02-13 2:17 ` Robert Eshleman
2019-02-13 3:25 ` Sven Van Asbroeck
2019-02-18 15:22 ` Jonathan Cameron
2019-02-18 17:13 ` Sven Van Asbroeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGngYiXz=o6m41wsETbt7i9c6Ut=GsW2Kvf8cwhqSQnO6Jg4zA@mail.gmail.com' \
--to=thesven73@gmail.com \
--cc=bobbyeshleman@gmail.com \
--cc=jic23@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).