From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio <linux-iio@vger.kernel.org>,
Barry Song <song.bao.hua@hisilicon.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 0/7] iio: Use IRQF_NO_AUTOEN
Date: Fri, 2 Apr 2021 22:00:17 +0300 [thread overview]
Message-ID: <CAHp75VcG7OQy-vmsOLXpamrkT_LBP6RoXRJ_vkCmxwG6eRS8DQ@mail.gmail.com> (raw)
In-Reply-To: <20210402184544.488862-1-jic23@kernel.org>
On Fri, Apr 2, 2021 at 9:48 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> This series is dependant on
> cbe16f35bee68 ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()")
> which is available in an immutable tag in the tip tree.
> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/tag/?h=irq-no-autoen-2021-03-25
> which I'll merge in to the IIO tree if we need it before it's available
> upstream.
>
> That patch introduces a new IRQF_NO_AUTOEN flag for irq requests to avoid
> the current dance where we either mark an irq as not to be autoenabled before
> we know if we can actually request it succesfully, or (as IIO drivers seem to
successfully
> have gone with) we disable the interrupt just after requesting it.
> In short the flag stops the interrupt being autoenabled in the first place.
>
> So this series applies this magic to IIO :)
>
> Note these are all just compile tested and some of them aren't entirely
> trivial because of other aspects of the irq flag handling.
I have looked at them and indeed in all cases it's clearer now what is going on.
FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Jonathan Cameron (7):
> iio:adc:ad7766: Use new IRQF_NO_AUTOEN to reduce boilerplate
> iio:adc:exynos-adc: Use new IRQF_NO_AUTOEN flag rather than separate
> irq_disable()
> iio:adc:nau7802: Use IRQF_NO_AUTOEN instead of request then disable
> iio:adc:sun4i-gpadc: Use new IRQF_NO_AUTOEN flag instead of request
> then disable
> iio:chemical:scd30: Use IRQF_NO_AUTOEN to avoid irq request then
> disable
> iio:imu:adis: Use IRQF_NO_AUTOEN instead of irq request then disable
> iio:adc:ad_sigma_delta: Use IRQF_NO_AUTOEN rather than request and
> disable
>
> drivers/iio/adc/ad7766.c | 15 +++++++--------
> drivers/iio/adc/ad_sigma_delta.c | 7 ++-----
> drivers/iio/adc/exynos_adc.c | 4 ++--
> drivers/iio/adc/nau7802.c | 6 +++---
> drivers/iio/adc/sun4i-gpadc-iio.c | 4 ++--
> drivers/iio/chemical/scd30_core.c | 16 ++++++++--------
> drivers/iio/imu/adis16460.c | 4 ++--
> drivers/iio/imu/adis16475.c | 5 +++--
> drivers/iio/imu/adis_trigger.c | 11 ++++++-----
> 9 files changed, 35 insertions(+), 37 deletions(-)
>
> --
> 2.31.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-04-02 19:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 18:45 [PATCH 0/7] iio: Use IRQF_NO_AUTOEN Jonathan Cameron
2021-04-02 18:45 ` [PATCH 1/7] iio:adc:ad7766: Use new IRQF_NO_AUTOEN to reduce boilerplate Jonathan Cameron
2021-04-02 20:10 ` Song Bao Hua (Barry Song)
2021-04-05 14:27 ` Jonathan Cameron
2021-04-02 18:45 ` [PATCH 2/7] iio:adc:exynos-adc: Use new IRQF_NO_AUTOEN flag rather than separate irq_disable() Jonathan Cameron
2021-04-02 20:11 ` Song Bao Hua (Barry Song)
2021-04-04 19:20 ` Krzysztof Kozlowski
2021-04-05 14:29 ` Jonathan Cameron
2021-04-02 18:45 ` [PATCH 3/7] iio:adc:nau7802: Use IRQF_NO_AUTOEN instead of request then disable Jonathan Cameron
2021-04-02 20:12 ` Song Bao Hua (Barry Song)
2021-04-05 14:33 ` Jonathan Cameron
2021-04-02 18:45 ` [PATCH 4/7] iio:adc:sun4i-gpadc: Use new IRQF_NO_AUTOEN flag " Jonathan Cameron
2021-04-02 20:13 ` Song Bao Hua (Barry Song)
2021-04-05 14:35 ` Jonathan Cameron
2021-04-02 18:45 ` [PATCH 5/7] iio:chemical:scd30: Use IRQF_NO_AUTOEN to avoid irq " Jonathan Cameron
2021-04-02 20:14 ` Song Bao Hua (Barry Song)
2021-04-05 14:36 ` Jonathan Cameron
2021-04-02 18:45 ` [PATCH 6/7] iio:imu:adis: Use IRQF_NO_AUTOEN instead of " Jonathan Cameron
2021-04-02 20:37 ` Song Bao Hua (Barry Song)
2021-04-05 14:40 ` Jonathan Cameron
2021-04-06 11:48 ` Sa, Nuno
2021-04-02 18:45 ` [PATCH 7/7] iio:adc:ad_sigma_delta: Use IRQF_NO_AUTOEN rather than request and disable Jonathan Cameron
2021-04-02 20:30 ` Song Bao Hua (Barry Song)
2021-04-05 14:51 ` Jonathan Cameron
2021-04-05 22:56 ` Song Bao Hua (Barry Song)
2021-04-02 19:00 ` Andy Shevchenko [this message]
2021-04-03 11:45 ` [PATCH 0/7] iio: Use IRQF_NO_AUTOEN Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcG7OQy-vmsOLXpamrkT_LBP6RoXRJ_vkCmxwG6eRS8DQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=song.bao.hua@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).