linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: humidity: hts221: move register definitions to sensor structs
Date: Sat, 7 Dec 2019 14:47:07 +0200	[thread overview]
Message-ID: <CAJ0CqmX-e0tC3x-Bfgb3i1qcQSHurt-g6uO7wkrDQ1T8B3DrOg@mail.gmail.com> (raw)
In-Reply-To: <20191207103927.035eda2a@archlinux>

>
> On Mon,  2 Dec 2019 12:23:28 +0200
> Lorenzo Bianconi <lorenzo@kernel.org> wrote:
>
> > Move some register definitions to hts221_avg_list, hts221_avg_list and
> > hts221_channels since they are used only there and simplify driver code
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> You could potentially switch this to GENMASK for the masks, but that can
> be a follow up patch if you want to do so.

Hi Jonathan,

ack, fine. I will post a patch.

Regards,
Lorenzo

>
> Applied to the togreg branch of iio.git and pushed out as testing for
> the autobuilders to play with it.
>
> Thanks,
>
> Jonathan
>
> > ---
> >  drivers/iio/humidity/hts221_core.c | 19 ++++++-------------
> >  1 file changed, 6 insertions(+), 13 deletions(-)
> >
> > diff --git a/drivers/iio/humidity/hts221_core.c b/drivers/iio/humidity/hts221_core.c
> > index 4922444771c6..9003671f14fb 100644
> > --- a/drivers/iio/humidity/hts221_core.c
> > +++ b/drivers/iio/humidity/hts221_core.c
> > @@ -24,13 +24,6 @@
> >  #define HTS221_REG_CNTRL1_ADDR               0x20
> >  #define HTS221_REG_CNTRL2_ADDR               0x21
> >
> > -#define HTS221_REG_AVG_ADDR          0x10
> > -#define HTS221_REG_H_OUT_L           0x28
> > -#define HTS221_REG_T_OUT_L           0x2a
> > -
> > -#define HTS221_HUMIDITY_AVG_MASK     0x07
> > -#define HTS221_TEMP_AVG_MASK         0x38
> > -
> >  #define HTS221_ODR_MASK                      0x03
> >  #define HTS221_BDU_MASK                      BIT(2)
> >  #define HTS221_ENABLE_MASK           BIT(7)
> > @@ -66,8 +59,8 @@ static const struct hts221_odr hts221_odr_table[] = {
> >
> >  static const struct hts221_avg hts221_avg_list[] = {
> >       {
> > -             .addr = HTS221_REG_AVG_ADDR,
> > -             .mask = HTS221_HUMIDITY_AVG_MASK,
> > +             .addr = 0x10,
> > +             .mask = 0x07,
> >               .avg_avl = {
> >                       4, /* 0.4 %RH */
> >                       8, /* 0.3 %RH */
> > @@ -80,8 +73,8 @@ static const struct hts221_avg hts221_avg_list[] = {
> >               },
> >       },
> >       {
> > -             .addr = HTS221_REG_AVG_ADDR,
> > -             .mask = HTS221_TEMP_AVG_MASK,
> > +             .addr = 0x10,
> > +             .mask = 0x38,
> >               .avg_avl = {
> >                       2, /* 0.08 degC */
> >                       4, /* 0.05 degC */
> > @@ -98,7 +91,7 @@ static const struct hts221_avg hts221_avg_list[] = {
> >  static const struct iio_chan_spec hts221_channels[] = {
> >       {
> >               .type = IIO_HUMIDITYRELATIVE,
> > -             .address = HTS221_REG_H_OUT_L,
> > +             .address = 0x28,
> >               .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
> >                                     BIT(IIO_CHAN_INFO_OFFSET) |
> >                                     BIT(IIO_CHAN_INFO_SCALE) |
> > @@ -114,7 +107,7 @@ static const struct iio_chan_spec hts221_channels[] = {
> >       },
> >       {
> >               .type = IIO_TEMP,
> > -             .address = HTS221_REG_T_OUT_L,
> > +             .address = 0x2a,
> >               .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
> >                                     BIT(IIO_CHAN_INFO_OFFSET) |
> >                                     BIT(IIO_CHAN_INFO_SCALE) |
>


      reply	other threads:[~2019-12-07 12:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 10:23 [PATCH] iio: humidity: hts221: move register definitions to sensor structs Lorenzo Bianconi
2019-12-07 10:39 ` Jonathan Cameron
2019-12-07 12:47   ` Lorenzo Bianconi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ0CqmX-e0tC3x-Bfgb3i1qcQSHurt-g6uO7wkrDQ1T8B3DrOg@mail.gmail.com \
    --to=lorenzo.bianconi@redhat.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).