From: Rob Herring <robh+dt@kernel.org>
To: Robert Jones <rjones@gateworks.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Mark Rutland <mark.rutland@arm.com>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: imu: add fxos8700 imu binding
Date: Thu, 10 Oct 2019 08:23:41 -0500 [thread overview]
Message-ID: <CAL_JsqKtRvpXH6JOcmcMivgnZu2e_ocL7Vd91_yX9VGd+W+dRw@mail.gmail.com> (raw)
In-Reply-To: <20191010012523.14426-2-rjones@gateworks.com>
On Wed, Oct 9, 2019 at 8:25 PM Robert Jones <rjones@gateworks.com> wrote:
>
> This adds documentation for the Freescale FXOS8700 Inertial Measurement Unit
> device-tree bindings.
>
> Signed-off-by: Robert Jones <rjones@gateworks.com>
> ---
> .../devicetree/bindings/iio/imu/fxos8700.yaml | 54 ++++++++++++++++++++++
Follow the compatible string name, so fsl,fxos8700.yaml.
> 1 file changed, 54 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/imu/fxos8700.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/imu/fxos8700.yaml b/Documentation/devicetree/bindings/iio/imu/fxos8700.yaml
> new file mode 100644
> index 0000000..f0dbf4b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/imu/fxos8700.yaml
> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/imu/fxos8700.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale FXOS8700 Inertial Measurement Unit
> +
> +maintainers:
> + - Robert Jones <rjones@gateworks.com>
> +
> +description: |
> + Accelerometer and magnetometer combo device with an i2c interface.
Also has a SPI interface.
> + https://www.nxp.com/products/sensors/motion-sensors/6-axis/digital-motion-sensor-3d-accelerometer-2g-4g-8g-plus-3d-magnetometer:FXOS8700CQ
> +
> +properties:
> + compatible:
> + enum:
> + - fsl,fxos8700
For a new binding, shouldn't this be nxp instead of fsl?
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + interrupt-names:
> + maxItems: 1
'const: INT1' instead. However, having '-names' doesn't really buy
much when there is only 1 entry, so I'd just drop it.
But then I read the datasheet and there are 2 interrupts, so you need
to describe 2 interrupts.
> +
> + drive-open-drain:
> + maxItems: 1
Should be boolean.
> +
> + spi-max-frequency:
> + maxItems: 1
spi-max-frequency is not an array. You should define the maximum for it.
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + fxos8700@1e {
> + compatible = "fsl,fxos8700";
> + reg = <0x1e>;
> +
> + interrupt-parent = <&gpio2>;
> + interrupts = <7 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "INT1";
> + };
> + };
> --
> 2.9.2
>
next prev parent reply other threads:[~2019-10-10 13:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 1:28 [PATCH 0/2] iio: imu: add support for FXOS8700 Robert Jones
2019-09-18 1:28 ` [PATCH 1/2] dt-bindings: iio: imu: add fxos8700 imu binding Robert Jones
2019-10-01 11:39 ` Rob Herring
2019-09-18 1:28 ` [PATCH 2/2] io: imu: Add support for the FXOS8700 IMU Robert Jones
2019-10-05 13:10 ` Jonathan Cameron
2019-10-10 1:25 ` [PATCH v2 0/2] iio: imu: add support for FXOS8700 Robert Jones
2019-10-10 1:25 ` [PATCH v2 1/2] dt-bindings: iio: imu: add fxos8700 imu binding Robert Jones
2019-10-10 13:23 ` Rob Herring [this message]
2019-10-10 1:25 ` [PATCH v2 2/2] iio: imu: Add support for the FXOS8700 IMU Robert Jones
2019-10-10 17:56 ` [PATCH v3 0/2] iio: imu: add support for FXOS8700 Robert Jones
2019-10-10 17:56 ` [PATCH v3 1/2] dt-bindings: iio: imu: add fxos8700 imu binding Robert Jones
2019-10-11 13:58 ` Rob Herring
2019-10-11 23:33 ` Bobby Jones
2019-10-14 13:37 ` Rob Herring
2019-10-10 17:56 ` [PATCH v3 2/2] iio: imu: Add support for the FXOS8700 IMU Robert Jones
2019-10-12 13:53 ` Jonathan Cameron
2019-10-14 18:33 ` Bobby Jones
2019-10-14 18:49 ` [PATCH v4 0/2] iio: imu: add support for FXOS8700 Robert Jones
2019-10-14 18:49 ` [PATCH v4 1/2] dt-bindings: iio: imu: add fxos8700 imu binding Robert Jones
2019-10-16 12:55 ` Rob Herring
2019-10-22 9:25 ` Jonathan Cameron
2019-10-14 18:49 ` [PATCH v4 2/2] iio: imu: Add support for the FXOS8700 IMU Robert Jones
2019-10-21 17:15 ` Bobby Jones
2019-10-22 9:25 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKtRvpXH6JOcmcMivgnZu2e_ocL7Vd91_yX9VGd+W+dRw@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=rjones@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).