From: Rob Herring <robh+dt@kernel.org>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] dt-bindings: iio: potentiometer: add max5432.yaml binding
Date: Mon, 29 Jul 2019 17:43:54 -0600 [thread overview]
Message-ID: <CAL_JsqLfMhR819mxTtam8AJQmy321-b1ut0az+tpPARE3HWzmg@mail.gmail.com> (raw)
In-Reply-To: <20190729114531.12386-2-martin@kaiser.cx>
On Mon, Jul 29, 2019 at 5:46 AM Martin Kaiser <martin@kaiser.cx> wrote:
>
> Add a binding for the Maxim Integrated MAX5432-MAX5435 family of digital
> potentiometers.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> changes in v3
> - split dt bindings and driver code into separate patches
> - use yaml format for dt bindings
> - fix formatting of parameter lists
>
> changes in v2
> - use MAX5432_ prefix for all defines
> - fix indentation
> - convert void * to unsigned long, not to u32
> (warning from kbuild test robot)
>
> .../bindings/iio/potentiometer/max5432.yaml | 35 ++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/potentiometer/max5432.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/potentiometer/max5432.yaml b/Documentation/devicetree/bindings/iio/potentiometer/max5432.yaml
> new file mode 100644
> index 000000000000..448781b80f39
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/potentiometer/max5432.yaml
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/potentiometer/max5432.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim Integrated MAX5432-MAX5435 Digital Potentiometers
> +
> +maintainers:
> + - Martin Kaiser <martin@kaiser.cx>
> +
> +description: |
> + Maxim Integrated MAX5432-MAX5435 Digital Potentiometers connected via I2C
> +
> + Datasheet:
> + https://datasheets.maximintegrated.com/en/ds/MAX5432-MAX5435.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - maxim,max5432
> + - maxim,max5433
> + - maxim,max5434
> + - maxim,max5435
> +
reg?
Also, add an 'additionalProperties: false' line. This means other
properties can't be present (except 'status' and a few we
automatically add).
> +examples:
> + - |
> + i2c0 {
i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + max5434@28 {
> + compatible = "maxim,max5434";
> + reg = <0x28>;
> + };
> + };
> --
> 2.11.0
>
next prev parent reply other threads:[~2019-07-29 23:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-21 17:59 [PATCH] iio: potentiometer: add a driver for Maxim 5432-5435 Martin Kaiser
2019-07-21 20:48 ` Peter Meerwald-Stadler
2019-07-22 20:13 ` kbuild test robot
2019-07-23 8:53 ` [PATCH v2] " Martin Kaiser
2019-07-27 20:45 ` Jonathan Cameron
2019-07-29 11:45 ` [PATCH v3 1/2] " Martin Kaiser
2019-07-29 11:45 ` [PATCH v3 2/2] dt-bindings: iio: potentiometer: add max5432.yaml binding Martin Kaiser
2019-07-29 23:43 ` Rob Herring [this message]
2019-07-31 14:07 ` [PATCH v4 1/2] iio: potentiometer: add a driver for Maxim 5432-5435 Martin Kaiser
2019-07-31 14:07 ` [PATCH v4 2/2] dt-bindings: iio: potentiometer: add max5432.yaml binding Martin Kaiser
2019-07-31 16:50 ` Rob Herring
2019-08-05 13:32 ` Jonathan Cameron
2019-08-05 13:30 ` [PATCH v4 1/2] iio: potentiometer: add a driver for Maxim 5432-5435 Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqLfMhR819mxTtam8AJQmy321-b1ut0az+tpPARE3HWzmg@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@kaiser.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).