* [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function dev_err()
@ 2021-11-05 1:55 Xu Wang
2021-11-08 10:40 ` Geert Uytterhoeven
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Xu Wang @ 2021-11-05 1:55 UTC (permalink / raw)
To: prabhakar.mahadev-lad.rj, jic23, lars
Cc: linux-iio, linux-renesas-soc, linux-kernel
The print function dev_err() is redundant because
platform_get_irq() already prints an error.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
drivers/iio/adc/rzg2l_adc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/iio/adc/rzg2l_adc.c b/drivers/iio/adc/rzg2l_adc.c
index 32fbf57c362f..9d5be52bd948 100644
--- a/drivers/iio/adc/rzg2l_adc.c
+++ b/drivers/iio/adc/rzg2l_adc.c
@@ -506,10 +506,8 @@ static int rzg2l_adc_probe(struct platform_device *pdev)
}
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(dev, "no irq resource\n");
+ if (irq < 0)
return irq;
- }
ret = devm_request_irq(dev, irq, rzg2l_adc_isr,
0, dev_name(dev), adc);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function dev_err()
2021-11-05 1:55 [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function dev_err() Xu Wang
@ 2021-11-08 10:40 ` Geert Uytterhoeven
2021-11-10 22:50 ` Prabhakar Mahadev Lad
2021-11-13 16:47 ` Jonathan Cameron
2 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-11-08 10:40 UTC (permalink / raw)
To: Xu Wang
Cc: Lad, Prabhakar, Jonathan Cameron, Lars-Peter Clausen, linux-iio,
Linux-Renesas, Linux Kernel Mailing List
On Fri, Nov 5, 2021 at 3:02 AM Xu Wang <vulab@iscas.ac.cn> wrote:
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function dev_err()
2021-11-05 1:55 [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function dev_err() Xu Wang
2021-11-08 10:40 ` Geert Uytterhoeven
@ 2021-11-10 22:50 ` Prabhakar Mahadev Lad
2021-11-13 16:47 ` Jonathan Cameron
2 siblings, 0 replies; 4+ messages in thread
From: Prabhakar Mahadev Lad @ 2021-11-10 22:50 UTC (permalink / raw)
To: Xu Wang, jic23, lars; +Cc: linux-iio, linux-renesas-soc, linux-kernel
Hi Xu,
Thank you for the patch.
> -----Original Message-----
> From: Xu Wang <vulab@iscas.ac.cn>
> Sent: 05 November 2021 01:55
> To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>; jic23@kernel.org; lars@metafoo.de
> Cc: linux-iio@vger.kernel.org; linux-renesas-soc@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function dev_err()
>
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
> drivers/iio/adc/rzg2l_adc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cheers,
Prabhakar
> diff --git a/drivers/iio/adc/rzg2l_adc.c b/drivers/iio/adc/rzg2l_adc.c index
> 32fbf57c362f..9d5be52bd948 100644
> --- a/drivers/iio/adc/rzg2l_adc.c
> +++ b/drivers/iio/adc/rzg2l_adc.c
> @@ -506,10 +506,8 @@ static int rzg2l_adc_probe(struct platform_device *pdev)
> }
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(dev, "no irq resource\n");
> + if (irq < 0)
> return irq;
> - }
>
> ret = devm_request_irq(dev, irq, rzg2l_adc_isr,
> 0, dev_name(dev), adc);
> --
> 2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function dev_err()
2021-11-05 1:55 [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function dev_err() Xu Wang
2021-11-08 10:40 ` Geert Uytterhoeven
2021-11-10 22:50 ` Prabhakar Mahadev Lad
@ 2021-11-13 16:47 ` Jonathan Cameron
2 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2021-11-13 16:47 UTC (permalink / raw)
To: Xu Wang
Cc: prabhakar.mahadev-lad.rj, lars, linux-iio, linux-renesas-soc,
linux-kernel
On Fri, 5 Nov 2021 01:55:04 +0000
Xu Wang <vulab@iscas.ac.cn> wrote:
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Applied, thanks
Jonathan
> ---
> drivers/iio/adc/rzg2l_adc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/rzg2l_adc.c b/drivers/iio/adc/rzg2l_adc.c
> index 32fbf57c362f..9d5be52bd948 100644
> --- a/drivers/iio/adc/rzg2l_adc.c
> +++ b/drivers/iio/adc/rzg2l_adc.c
> @@ -506,10 +506,8 @@ static int rzg2l_adc_probe(struct platform_device *pdev)
> }
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(dev, "no irq resource\n");
> + if (irq < 0)
> return irq;
> - }
>
> ret = devm_request_irq(dev, irq, rzg2l_adc_isr,
> 0, dev_name(dev), adc);
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-13 16:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-05 1:55 [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function dev_err() Xu Wang
2021-11-08 10:40 ` Geert Uytterhoeven
2021-11-10 22:50 ` Prabhakar Mahadev Lad
2021-11-13 16:47 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).